PR feedback.

tractorcow-farm · Feb 6, 2025 · 2c50278 · 2c50278
1 parent 5d2bea0
commit 2c50278
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 16 deletions.
diff --git a/_config/model.yml b/_config/model.yml
@@ -2,11 +2,6 @@
 Name: fluentmodel
 ---
 SilverStripe\ORM\DataObject:
-  # See FluentExtension
-  cms_localisation_required: any
-  frontend_publish_required: fallback
-  # See FluentFilteredExtension
-  apply_filtered_locales_to_stage: true
   # See FluentIsolatedExtension
   apply_isolated_locales_to_admin: true # Set to false to disable entirely in CMS
   apply_isolated_locales_to_byid: true # Set to false to disable for id/fk filters in CMS

diff --git a/src/Extension/FluentExtension.php b/src/Extension/FluentExtension.php
@@ -48,7 +48,6 @@
  *
  * @template T of DataObject
  * @extends DataExtension<T&static>
- * @property DataObject|$this $owner
  */
 class FluentExtension extends DataExtension
 {
@@ -88,17 +87,11 @@ class FluentExtension extends DataExtension
 
     /**
      * Fluent inheritance mode for CMS context
-     *
-     * @var string
-     * @config
      */
     private static string $cms_localisation_required = FluentExtension::INHERITANCE_MODE_ANY;
 
     /**
      * Fluent inheritance mode for frontend context
-     *
-     * @var string
-     * @config
      */
     private static string $frontend_publish_required = FluentExtension::INHERITANCE_MODE_FALLBACK;
 

diff --git a/src/Extension/FluentFilteredExtension.php b/src/Extension/FluentFilteredExtension.php
@@ -36,11 +36,8 @@ class FluentFilteredExtension extends DataExtension
 
     /**
      * Allow the filtered locale behaviour to be skipped for draft stage only
-     *
-     * @var bool
-     * @config
      */
-    private static bool $apply_filtered_locales_to_stage = false;
+    private static bool $apply_filtered_locales_to_stage = true;
 
     private static $many_many = [
         'FilteredLocales' => Locale::class,