Remove parseLocals cache (#73)

* Remove parseLocals cache

* Remove unused files

Co-authored-by: dmattia <david@transcend.io>

Makefile

@@ -1,4 +1,4 @@
-VERSION=0.9.6
+VERSION=0.9.7
 PATH_BUILD=build/
 FILE_COMMAND=terragrunt-atlantis-config
 FILE_ARCH=darwin_amd64

README.md

@@ -158,7 +158,7 @@ jobs:
         id: atlantis_validator
         uses: transcend-io/terragrunt-atlantis-config-github-action@v0.0.3
         with:
-          version: v0.9.6
+          version: v0.9.7
           extra_args: '--autoplan --parallel=false
 ```
 

cmd/golden/mergeParentDependencies.yaml

@@ -12,4 +12,15 @@ projects:
     - ../../parent/folder_under_parent/common_tags.hcl
     - some_child_dep
   dir: deep/child
+- autoplan:
+    enabled: false
+    when_modified:
+    - '*.hcl'
+    - '*.tf*'
+    - some_parent_dep
+    - local_tags.yaml
+    - ../file_in_parent_of_child.json
+    - ../../parent/folder_under_parent/common_tags.hcl
+    - some_child_dep
+  dir: deep_with_local_tags_file/child
 version: 3

cmd/parse_locals.go

@@ -15,15 +15,6 @@ import (
 	"path/filepath"
 )
 
-var (
-	parseLocalsCache map[string]ParseLocalResult = make(map[string]ParseLocalResult)
-)
-
-type ParseLocalResult struct {
-	resolvedLocals ResolvedLocals
-	err            error
-}
-
 // ResolvedLocals are the parsed result of local values this module cares about
 type ResolvedLocals struct {
 	// The Atlantis workflow to use for some project
@@ -54,28 +45,21 @@ func parseHcl(parser *hclparse.Parser, hcl string, filename string) (file *hcl.F
 
 // Parses a given file, returning a map of all it's `local` values
 func parseLocals(path string, terragruntOptions *options.TerragruntOptions, includeFromChild *config.IncludeConfig) (ResolvedLocals, error) {
-	if cachedResult, ok := parseLocalsCache[path]; ok {
-		return cachedResult.resolvedLocals, cachedResult.err
-	}
-
 	configString, err := util.ReadFileAsString(path)
 	if err != nil {
-		parseLocalsCache[path] = ParseLocalResult{err: err}
 		return ResolvedLocals{}, err
 	}
 
 	// Parse the HCL string into an AST body
 	parser := hclparse.NewParser()
 	file, err := parseHcl(parser, configString, path)
 	if err != nil {
-		parseLocalsCache[path] = ParseLocalResult{err: err}
 		return ResolvedLocals{}, err
 	}
 
 	// Decode just the Base blocks. See the function docs for DecodeBaseBlocks for more info on what base blocks are.
 	localsAsCty, _, includeConfig, err := config.DecodeBaseBlocks(terragruntOptions, parser, file, path, includeFromChild)
 	if err != nil {
-		parseLocalsCache[path] = ParseLocalResult{err: err}
 		return ResolvedLocals{}, err
 	}
 
@@ -98,7 +82,6 @@ func parseLocals(path string, terragruntOptions *options.TerragruntOptions, incl
 		)
 	}
 
-	parseLocalsCache[path] = ParseLocalResult{resolvedLocals: parentLocals}
 	return parentLocals, nil
 }
 

main.go

@@ -5,7 +5,7 @@ import "github.com/transcend-io/terragrunt-atlantis-config/cmd"
 // This variable is set at build time using -ldflags parameters.
 // But we still set a default here for those using plain `go get` downloads
 // For more info, see: http://stackoverflow.com/a/11355611/483528
-var VERSION string = "0.9.6"
+var VERSION string = "0.9.7"
 
 func main() {
 	cmd.Execute(VERSION)

test_examples/parent_with_extra_deps/deep_with_local_tags_file/child/local_tags.yaml

@@ -0,0 +1 @@
+some_tag_key: some_tag_value

test_examples/parent_with_extra_deps/deep_with_local_tags_file/child/terragrunt.hcl

@@ -0,0 +1,17 @@
+include {
+  path = "${find_in_parent_folders("parent")}/terragrunt.hcl"
+}
+
+terraform {
+  source = "git::git@github.com:transcend-io/terraform-aws-fargate-container?ref=v0.0.4"
+}
+
+locals {
+  extra_atlantis_dependencies = [
+    "some_child_dep",
+  ]
+}
+
+inputs = {
+  foo = "bar"
+}

test_examples/parent_with_extra_deps/deep_with_local_tags_file/file_in_parent_of_child.json

@@ -0,0 +1,3 @@
+{
+    "noice": "no ice"
+}

test_examples/parent_with_extra_deps/parent/terragrunt.hcl

@@ -3,6 +3,9 @@ locals {
     # A relative file to the child should work
     "some_parent_dep",
 
+    # Relative files to the child should be conditionally includable
+    fileexists("${path_relative_to_include()}/local_tags.yaml") ? "local_tags.yaml" : "",
+
     # Functions should run from the child dir, not the parent dir
     find_in_parent_folders("file_in_parent_of_child.json"),
     "${get_parent_terragrunt_dir()}/folder_under_parent/common_tags.hcl",