Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ioutil calls #308

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

relu
Copy link
Contributor

@relu relu commented Jan 30, 2024

Replacing deprecated ioutil calls with the respective os counterparts.

Depends on #307.

@dmattia dmattia self-requested a review February 7, 2024 03:25
Copy link
Member

@dmattia dmattia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good if #307 merges

@Almenon
Copy link
Collaborator

Almenon commented Feb 10, 2024

@relu can you rebase so the latest test suite can run please?

@relu relu force-pushed the replace-ioutil-references branch from b9b7b4e to de972eb Compare February 12, 2024 20:11
@Almenon
Copy link
Collaborator

Almenon commented Feb 17, 2024

Rebasing just caused the tests to fail again because of a buggy PR #286, my bad. I've checked out your branch and ran the unit tests along with the fixes in #311 and confirmed it works. Approved.

@Almenon
Copy link
Collaborator

Almenon commented Feb 17, 2024

I'll cut a new release once #311 is merged in, want to confirm unit tests pass in CI.

@Almenon Almenon merged commit 80ee8a0 into transcend-io:master Feb 17, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants