B-21378: UB RDD Remove Starting Day After Pickup

[TevinAdams]

Agility ticket

I-13936

Summary

Was brought up in POA that the day was off by one. Adding the transit time to the day after scheduled pickup date is not what is wanted. I am removing that logic here. Testing is the same. Take the scheduled pickup date plus the transit time. NOT day after pickup date.

Is there anything you would like reviewers to give additional scrutiny?

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Create a UB shipment as a MyMove user

• Use addresses that have a us_post_region_cities_id that exist in a record in re_oconus_rate_areas table
• Current address I used an address in zipcode 29229
• Current duty location: Fort Jackson
• Duty Location: Use a duty location that has an address that has a us_post_region_cities_id in re_oconus_rate_areas. In my case I used Eielson, AFB

2. As SC counsel move
3. As TOO approve move
4. As Prime update the shipment with a scheduled pickup date
5. Check the shipment in the DB and make sure the Required delivery date is populated

Different addresses and the ubTransitTimes added: add the UBTransit time to the scheduled pickup day.
(Pickup Address, Destination Address, UbTransitTime)
(GA, Chugach AK 99686 (AK Zone I ), 23)
(MN, Chicken AK 99732 (AK Zone II ), 21)
(WV, Anderson AK 99744 (AK Zone II ), 23)
(WV, Kodiak AK 99697 (AK Zone III ), 27)
(NC, Ketchikan AK 99901 (AK Zone IV), 27)
(Chugach AK 99686 (AK Zone I ), OR, 17)

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots