-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix server tests, remove ghcimport test suite: integrationTesting #14969
Open
traskowskycaci
wants to merge
10
commits into
integrationTesting
Choose a base branch
from
remove-ghcimport-test-suite-integration
base: integrationTesting
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix server tests, remove ghcimport test suite: integrationTesting #14969
traskowskycaci
wants to merge
10
commits into
integrationTesting
from
remove-ghcimport-test-suite-integration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server test also passing in gitlab: https://gitlab.csde.caci.com/milmove/mymove/-/jobs/7785625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAIN PR
Summary
Int specific commits I made that need to make their way to main:
ea2bcb0: Going into main with this BL
8f2fbe5: Going into main with this PR
0f030d1: Going into main with this BL
050072d: Going into main with this PR
Important
This PR sets the
server_test
gitlab step to be required.Summary
For some background, you can read through the description on a previous PR for a different test fix caused by the same issue.
In short - we lost some database permissions when we upgraded to postgres awhile back. "PostgreSQL 15 also revokes the CREATE permission from all users except a database owner from the public (or default) schema" per this and this. If you poked around in ghcimport, you'd run into something akin to
permission denied for schema public
.For the sequencer test fix made in that linked PR above, I was able to get around it by making it a migration rather than the test doing some database stuff. However, since the ghcimport tests basically all need to be doing database stuff - altering tables, creating tables, etc. - all the tests in that package are pretty much toast.
I was going to delete the whole ghcimport folder, but that would impact cmd/ghc-pricing-parser/main.go. So, settling for deleting the tests for now.
There were a few failing tests in
pkg/services/mto_service_item
andpkg/service/mto_shipment
that must've been hiding behind that ghcimport failure - fixed those as well