Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server tests, remove ghcimport test suite: integrationTesting #14969

Open
wants to merge 10 commits into
base: integrationTesting
Choose a base branch
from

Conversation

traskowskycaci
Copy link
Contributor

@traskowskycaci traskowskycaci commented Mar 6, 2025

MAIN PR

Summary

Int specific commits I made that need to make their way to main:

Important

This PR sets the server_test gitlab step to be required.

Summary

  • Removed ghcimport tests
  • Fixed tests in pkg/services/mto_service_item
  • Fixed tests in pkg/service/mto_shipment

For some background, you can read through the description on a previous PR for a different test fix caused by the same issue.

In short - we lost some database permissions when we upgraded to postgres awhile back. "PostgreSQL 15 also revokes the CREATE permission from all users except a database owner from the public (or default) schema" per this and this. If you poked around in ghcimport, you'd run into something akin to permission denied for schema public.

For the sequencer test fix made in that linked PR above, I was able to get around it by making it a migration rather than the test doing some database stuff. However, since the ghcimport tests basically all need to be doing database stuff - altering tables, creating tables, etc. - all the tests in that package are pretty much toast.

I was going to delete the whole ghcimport folder, but that would impact cmd/ghc-pricing-parser/main.go. So, settling for deleting the tests for now.

There were a few failing tests in pkg/services/mto_service_item and pkg/service/mto_shipment that must've been hiding behind that ghcimport failure - fixed those as well

@traskowskycaci traskowskycaci requested a review from JonSpight March 6, 2025 20:21
@traskowskycaci traskowskycaci self-assigned this Mar 6, 2025
@traskowskycaci traskowskycaci changed the title Remove ghcimport test suite integration Remove ghcimport test suite: integrationTesting Mar 6, 2025
@traskowskycaci traskowskycaci changed the title Remove ghcimport test suite: integrationTesting Fix server tests, remove ghcimport test suite: integrationTesting Mar 6, 2025
@traskowskycaci
Copy link
Contributor Author

Server tests passing locally with latest int pulled in as of 4:16 central on 3/6:
image

@traskowskycaci traskowskycaci added the INTEGRATION Slated for Integration Testing label Mar 6, 2025
@traskowskycaci traskowskycaci requested review from a team, deandreJones and TevinAdams March 6, 2025 22:17
@traskowskycaci traskowskycaci marked this pull request as ready for review March 6, 2025 23:36
@traskowskycaci traskowskycaci requested a review from a team as a code owner March 6, 2025 23:36
@traskowskycaci
Copy link
Contributor Author

server test also passing in gitlab: https://gitlab.csde.caci.com/milmove/mymove/-/jobs/7785625

@traskowskycaci traskowskycaci requested a review from a team as a code owner March 6, 2025 23:44
@traskowskycaci traskowskycaci requested a review from a team as a code owner March 7, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing
Development

Successfully merging this pull request may close these issues.

1 participant