Save state on refresh, use URL state #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbychaskell
requested review from
idreyn,
mathcolo and
devinmatte
as code owners
github-actions
bot
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses Issue #148
Moving the state to the query string also makes it easier to share specific views by and copying the link. Also could be nice to be able to bookmark a specific line + train type.
Changes
Adds React Router dependency
Primarily replaces the tabState with customHooks based on the useSearchParams hooks from React Router. Age and Line selection are stored in the query string.
Testing Instructions
Test changing lines and train ages. Page should stay the same on refresh or from bookmarking.