Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: radio group #808

Closed
wants to merge 11 commits into from
Closed

feat: radio group #808

wants to merge 11 commits into from

Conversation

jzfrank
Copy link
Contributor

@jzfrank jzfrank commented Nov 12, 2023

Description
Add Radio Group. e.g. for pricing component

Related issue(s)

What kind of change does this PR introduce? (check at least one)

  • Bug fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

How has This been tested?

Screenshots (if appropriate):
image

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the related issue section above
  • My change requires a change to the documentation. (Managed by Tremor Team)
  • I have added tests to cover my changes
  • Check the "Allow edits from maintainers" option while creating your PR.
  • Add refs #XXX or fixes #XXX to the related issue section if your PR refers to or fixes an issue.
  • By contributing to Tremor, you confirm that you have read and agreed to Tremor's CONTRIBUTING.md guideline. You also agree that your contributions will be licensed under the Apache License 2.0 license.

Copy link

vercel bot commented Nov 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tremor-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2023 0:03am

@jzfrank jzfrank changed the title Feat: radio group feat: radio group Nov 12, 2023
@severinlandolt severinlandolt marked this pull request as ready for review December 9, 2023 00:53
@severinlandolt severinlandolt added the PR: In Review This PR is in the process of being reviewed by the team label Dec 9, 2023
@severinlandolt
Copy link
Member

Thank you @jzfrank for your groundwork! As you can see from the commit history, we came full circle with this component. I checked out this branch to a new one feat/choicebox to get rid of my no longer needed commits. We want to apply some more changes, that are most probably of breaking nature, hence I will close this PR and take it continue to work on feat/choicebox.

@jzfrank
Copy link
Contributor Author

jzfrank commented Dec 13, 2023

Thank you @jzfrank for your groundwork! As you can see from the commit history, we came full circle with this component. I checked out this branch to a new one feat/choicebox to get rid of my no longer needed commits. We want to apply some more changes, that are most probably of breaking nature, hence I will close this PR and take it continue to work on feat/choicebox.

Pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: In Review This PR is in the process of being reviewed by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: RadioButton Component
3 participants