feat(ci): unused translations auto cleanup #13444
Conversation
martykan
force-pushed
the
feat/unused-translations-auto-cleanup
branch
3 times, most recently
from
3187f48 to
a0138aa
Compare
| name: "[Check] remove unused messages and create PR" | ||
|
|
||
| on: | ||
| workflow_dispatch: |
There was a problem hiding this comment.
@karliatto would you please take over this PR and incorporate into as a nightly check similarly to what you are doing now?
There was a problem hiding this comment.
Is it necessary to add another action? You're also not using some naming convention for the file. We can add it to the same action but just add a trigger that checks if the action was scheduled to run to only do this instead of updating it.
There was a problem hiding this comment.
It's originally part of [test] misc which runs nightly, but I didn't set that up to automatically create PRs, since it could potentially create duplicate PRs if the first one is not merged right away.
Also I have another idea - maybe this could happen as a part of Crowdin sync?
There was a problem hiding this comment.
Yes, doing this every time you sync crowdin seems a bit better to me. 👍
There was a problem hiding this comment.
So what is the final idea? will it be run with the Crowding sync or with this workflow as well?
There was a problem hiding this comment.
Please add it to the Crowdin sync. It should run before the upload to Crowdin.
There was a problem hiding this comment.
The upload also deletes from Crowdin? I'm just thinking whether it would be dangerous if someone ran it without checking the unused strings prior
There was a problem hiding this comment.
If a key does not exist in messages.ts, Crowdin sync deletes it from Crowdin and the translation JSONs. Can there be false positives from the script removing unused messages? If so, it has to be run separately.
There was a problem hiding this comment.
Most likely not, except for the possibility of dynamic strings that are not marked as such.
There was a problem hiding this comment.
I added a checkbox as an input to confirm removing to make it safer
martykan
force-pushed
the
feat/unused-translations-auto-cleanup
branch
2 times, most recently
from
5d8d546 to
8312818
Compare
martykan
force-pushed
the
feat/unused-translations-auto-cleanup
branch
from
8312818 to
42d3835
Compare
Description
Adds a
--cleanupoption to thetranslations:list-unusedscript, which automatically removes the unused messages from the file.The script also includes a
--proption, which will create a new branch with this change and submit a PR.This can be run from a new workflow in GitHub actions. The workflow is triggered manually to prevent too many PRs being created.