Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] fix(connect): fix device getting into hanged state after app reload #15790

Closed
wants to merge 1 commit into from
Closed

[wip] fix(connect): fix device getting into hanged state after app reload #15790

wants to merge 1 commit into from

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented Dec 5, 2024 •
edited
Loading

Before:

  1. go to suite (webusb)
  2. get address
  3. reload
  4. observe that the device is stuck

After:

  • sending cancel seems to be the universal remedy, that flushes all the communication and forces the device to cooperate again after exiting the initial communication ungracefully.

this appears to be fixing a couple of issues, for example:

@mroz22 mroz22 force-pushed the fix-hang-device-after-reload branch from 76c04af to c6d2d0a Compare January 15, 2025 12:03
@mroz22 mroz22 added the no-project This label is used to specify that PR doesn't need to be added to a project label Jan 16, 2025
@mroz22 mroz22 force-pushed the fix-hang-device-after-reload branch 2 times, most recently from 380721a to bf53c71 Compare January 16, 2025 17:11
@mroz22 mroz22 force-pushed the fix-hang-device-after-reload branch from bf53c71 to 174de2b Compare January 21, 2025 13:53
@mroz22
Copy link
Contributor Author

mroz22 commented Jan 22, 2025

closing in favor of #16528

@mroz22 mroz22 closed this Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymonlesisz szymonlesisz Awaiting requested review from szymonlesisz szymonlesisz will be requested when the pull request is marked ready for review szymonlesisz is a code owner

@martykan martykan Awaiting requested review from martykan martykan will be requested when the pull request is marked ready for review martykan is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak marekrjpolak will be requested when the pull request is marked ready for review marekrjpolak is a code owner

Assignees
No one assigned
Labels
no-project This label is used to specify that PR doesn't need to be added to a project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mroz22