Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update sentry #16223

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Chore/update sentry #16223

merged 3 commits into from
Jan 7, 2025

Conversation

komret
Copy link
Contributor

@komret komret commented Jan 7, 2025

Description

Update Sentry to fix the discrepancy between mobile and desktop which resulted in logs not being collected from desktop. Originated here.

@komret komret added the dependencies Pull requests that update a dependency file label Jan 7, 2025
@komret komret requested a review from marekrjpolak January 7, 2025 11:48
@komret komret requested review from a team and Nodonisko as code owners January 7, 2025 11:48
},
// If Tor is enabled but not running, don't send the event but put it in a queue.
// Queue can be inspected in @trezor/suite-desktop/sentry/queue folder.
shouldSend: () => !(store.getTorSettings().running && torStatus !== TorStatus.Enabled),
Copy link
Contributor Author

@komret komret Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API change, see documentation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for troubles I didn't expect it could affect desktop and TS won't even complain

levels: ['error'],
}),
new Dedupe(),
Copy link
Contributor Author

@komret komret Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enabled by default, see documentation.

Copy link

socket-security bot commented Jan 7, 2025

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Wildcard dependency npm/@types/pg@8.6.1 🚫
Wildcard dependency npm/@types/pg@8.6.1 🚫
Shell access npm/@opentelemetry/resources@1.30.0 🚫
Shell access npm/@opentelemetry/resources@1.30.0 🚫

View full report↗︎

Next steps

What are wildcard dependencies?

Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version.

Packages should specify properly semver ranges to avoid version conflicts.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@types/pg@8.6.1
  • @SocketSecurity ignore npm/@opentelemetry/resources@1.30.0

Copy link

github-actions bot commented Jan 7, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 21
  • More info

Learn more about 𝝠 Expo Github Action

Copy link
Contributor

@marekrjpolak marekrjpolak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@komret komret force-pushed the chore/update-sentry branch from 9be74c4 to 5a2adab Compare January 7, 2025 12:58
@komret komret force-pushed the chore/update-sentry branch from 5a2adab to 0a001c8 Compare January 7, 2025 13:00
@komret komret merged commit 0093ee1 into develop Jan 7, 2025
74 of 78 checks passed
@komret komret deleted the chore/update-sentry branch January 7, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants