-
-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/update sentry #16223
Chore/update sentry #16223
Conversation
}, | ||
// If Tor is enabled but not running, don't send the event but put it in a queue. | ||
// Queue can be inspected in @trezor/suite-desktop/sentry/queue folder. | ||
shouldSend: () => !(store.getTorSettings().running && torStatus !== TorStatus.Enabled), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API change, see documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for troubles I didn't expect it could affect desktop and TS won't even complain
levels: ['error'], | ||
}), | ||
new Dedupe(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enabled by default, see documentation.
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat are wildcard dependencies?Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version. Packages should specify properly semver ranges to avoid version conflicts. What is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
🚀 Expo preview is ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9be74c4
to
5a2adab
Compare
…nd @sentry/electron
5a2adab
to
0a001c8
Compare
Description
Update Sentry to fix the discrepancy between mobile and desktop which resulted in logs not being collected from desktop. Originated here.