Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(request-manager): intercept for fetch nodejs native #16488

Merged
merged 5 commits into from
Jan 23, 2025
Merged

feat(request-manager): intercept for fetch nodejs native #16488

merged 5 commits into from
Jan 23, 2025

Conversation

karliatto
Copy link
Member

@karliatto karliatto commented Jan 21, 2025 •
edited
Loading

Description

  1. Add interceptFetch to request-manager and use it in the tests.
  2. Fix and make request-manager critical tests running in CI in schedule
  3. Fix little typo in suite-desktop-core test that was bridge-thor and it should be bridge-tor.

@karliatto karliatto changed the title test(suite-desktop-core): fix typo in Tor tests and enable it. wip: test(suite-desktop-core): fix typo in Tor tests and enable it. Jan 21, 2025
@karliatto karliatto force-pushed the test/make-tor-tests-great-again branch 2 times, most recently from 6314785 to 349bf32 Compare January 21, 2025 16:24
karliatto
karliatto commented Jan 21, 2025
View reviewed changes
packages/request-manager/src/interceptor/interceptFetch.ts Outdated
// See issue: https://github.com/TooTallNate/proxy-agents/issues/239 .
import type { RequestOptions } from 'https';

import nodeFetch from 'cross-fetch';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using cross-fetch before, we also have node-fetch and it should work with both since they use the same old API http.request.

@karliatto karliatto changed the title wip: test(suite-desktop-core): fix typo in Tor tests and enable it. feat(request-manager): intercept for fetch nodejs native Jan 21, 2025
@karliatto karliatto force-pushed the test/make-tor-tests-great-again branch from 3e5dfdc to d30b3b3 Compare January 21, 2025 17:11
@karliatto karliatto marked this pull request as ready for review January 21, 2025 17:12
@karliatto karliatto requested a review from vdovhanych as a code owner January 21, 2025 17:12
@karliatto karliatto force-pushed the test/make-tor-tests-great-again branch from d30b3b3 to ebf138f Compare January 22, 2025 08:14
@karliatto karliatto force-pushed the test/make-tor-tests-great-again branch from 5c7df5b to c4a4dd4 Compare January 23, 2025 15:45
@karliatto
Copy link
Member Author

@peter-sanderson I ended-up rebasing with current develop.

peter-sanderson
peter-sanderson approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@peter-sanderson peter-sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karliatto ✔️

@karliatto karliatto merged commit 8aa03be into develop Jan 23, 2025
30 of 31 checks passed
@karliatto karliatto deleted the test/make-tor-tests-great-again branch January 23, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peter-sanderson peter-sanderson peter-sanderson approved these changes

@vdovhanych vdovhanych Awaiting requested review from vdovhanych vdovhanych is a code owner

@marekrjpolak marekrjpolak Awaiting requested review from marekrjpolak

@mroz22 mroz22 Awaiting requested review from mroz22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karliatto @vdovhanych @peter-sanderson