Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suite-native): use linear gradient in screen footers with buttons #16608

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

yanascz
Copy link
Contributor

@yanascz yanascz commented Jan 27, 2025

ScreenFooterGradient component introduced and used where appropriate.

Related to #14856

@yanascz yanascz added the mobile Suite Lite issues and PRs label Jan 27, 2025
@yanascz yanascz self-assigned this Jan 27, 2025
@yanascz yanascz requested a review from a team as a code owner January 27, 2025 08:36
@yanascz yanascz force-pushed the fix/native/screen-footer-gradient branch from cc63c2a to 14cbbd1 Compare January 27, 2025 08:38
Copy link

github-actions bot commented Jan 27, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 23
  • More info

Learn more about 𝝠 Expo Github Action

@yanascz yanascz requested a review from PeKne January 28, 2025 08:39
@yanascz yanascz force-pushed the fix/native/screen-footer-gradient branch from 59e189b to 2f9a805 Compare January 28, 2025 10:34
@yanascz yanascz force-pushed the fix/native/screen-footer-gradient branch from 2f9a805 to 2fb5d13 Compare January 28, 2025 11:07
@yanascz yanascz merged commit 7627386 into develop Jan 28, 2025
79 of 80 checks passed
@yanascz yanascz deleted the fix/native/screen-footer-gradient branch January 28, 2025 12:30
@STew790
Copy link
Contributor

STew790 commented Feb 10, 2025

QA OK
LGTM, the animations feel way smoother now 🖤

Info
25.1.3 e549011

@STew790 STew790 added the QA OK Issue passed QA without any blocker label Feb 10, 2025
Copy link

coderabbitai bot commented Feb 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request refactors how gradient effects are handled in several modules. It removes the direct dependency on expo-linear-gradient from the coin-enabling module and replaces the usage of the LinearGradient component with the new ScreenFooterGradient component imported from the navigation package. The change extends to multiple screens where footer layouts have been updated to simplify styling and remove redundant style definitions. Additionally, the coin-enabling TypeScript configuration is updated by removing an unused reference, and the firmware update screen receives a minor style tweak with an added bottom margin. The navigation package now includes the expo-linear-gradient dependency and exports the new ScreenFooterGradient component, ensuring consistency across the application when rendering footer gradients.

Possibly related PRs

Suggested reviewers

  • Nodonisko
  • mroz22
  • tomasklim

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e7b10fe and 2fb5d13.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (9)
  • suite-native/coin-enabling/package.json (0 hunks)
  • suite-native/coin-enabling/src/screens/CoinEnablingInitScreen.tsx (2 hunks)
  • suite-native/coin-enabling/tsconfig.json (0 hunks)
  • suite-native/module-accounts-import/src/components/AccountImportSummaryScreen.tsx (2 hunks)
  • suite-native/module-device-settings/src/screens/FirmwareUpdateScreen/FirmwareUpdateScreen.tsx (1 hunks)
  • suite-native/module-send/src/screens/SendOutputsScreen.tsx (2 hunks)
  • suite-native/navigation/package.json (1 hunks)
  • suite-native/navigation/src/components/ScreenFooterGradient.tsx (1 hunks)
  • suite-native/navigation/src/index.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants