add driver for snowflake/mysql #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u110
force-pushed
the
driver-for-snowflake-mysql
branch
from
7fd1453 to
5d7fdbe
Compare
okeyaki
reviewed
Feb 21, 2025
| @@ -569,10 +569,28 @@ func (r *connectionResource) Schema( | |||
|
|
|||
| // PostgreSQL Fields | |||
| "driver": schema.StringAttribute{ | |||
| MarkdownDescription: "PostgreSQL: The name of a PostgreSQL driver.", | |||
| Optional: true, | |||
| MarkdownDescription: strings.Join( | |||
There was a problem hiding this comment.
IMO: It's better to use multiline string syntax.
MarkdownDescription: `
Snowflake, MySQL, PostgreSQL: The name of a Database driver. Possible values are:
- MySQL: null, mysql_connector_java_5_1_49
- Snowflake: null, snowflake_jdbc_3_14_2, snowflake_jdbc_3_17_0
- PostgreSQL: postgresql_42_5_1, postgresql_9_4_1205_jdbc41
`
okeyaki
reviewed
Feb 21, 2025
| // PostgreSQL | ||
| "postgresql_42_5_1", | ||
| "postgresql_9_4_1205_jdbc41", | ||
| ), | ||
| }, |
There was a problem hiding this comment.
ASK: Is it necessary to validate the combination of driver and connection type?
u110
force-pushed
the
driver-for-snowflake-mysql
branch
from
3947107 to
a18ee95
Compare
okeyaki
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
connectionresource to support additional database drivers and improve the handling of thedriverfield. The most important changes include updating the documentation, modifying theCreateConnectionInputandUpdateConnectionInputstructs, and enhancing the schema for thedriverfield.Support for additional database drivers:
docs/resources/connection.md: Updated thedriverfield description to include support for Snowflake and MySQL drivers, in addition to PostgreSQL. Added possible values for each database type.Handling of the
driverfield:internal/client/connection.go: Changed the type of theDriverfield in bothCreateConnectionInputandUpdateConnectionInputstructs from*stringto*parameter.NullableString. [1] [2]internal/provider/connection_resource.go: Updated theToCreateConnectionInputandToUpdateConnectionInputmethods to usemodel.NewNullableStringfor theDriverfield. [1] [2]internal/provider/connection_resource.go: Enhanced the schema for thedriverfield to include descriptions and validators for the new database types and their respective possible values.