Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

article addressing performance concerns with the current schema #112

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

catkins-miso
Copy link
Contributor

@catkins-miso catkins-miso commented Jun 23, 2024

closes #108

@catkins-miso catkins-miso added the Task catch-all for tasks not associated with spec changes label Jun 23, 2024
Copy link
Contributor

@getorymckeag getorymckeag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good. I left some minor comments, but I also feel like you could lean into our expected interop problems a bit. You don't have to lay it all our here, but we've designed intentional verbosity in this protocol in a couple of areas. You already talked about the issues around periods, but I was thinking about the following:

  • Model mismatches, naming convention mismatches (big one)
  • Differences in units
  • Differences in forecast windows.

@catkins-miso
Copy link
Contributor Author

@catkins-miso
Copy link
Contributor Author

I'm going to merge this as I believe I've addressed the requested changes. I'm going to solicit feedback from a few individuals, so I'd like to get this out there and easy legible on trolie.energy

@catkins-miso catkins-miso merged commit 9fde888 into 1.0.0-wip Jun 24, 2024
3 checks passed
@catkins-miso catkins-miso deleted the perf-tradeoffs branch November 15, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task catch-all for tasks not associated with spec changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

address performance concerns with period representation
2 participants