Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to new Astro 5.1.3 version #25

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Conversation

trueberryless
Copy link
Member

@trueberryless trueberryless commented Jan 8, 2025

Description

In Astro 5.1.2 there was a bug 🐛 , where the server islands returned 404 with some adapters. This also applied for the Node adapter.

In Astro 5.1.3 this issue seems to have been fixed, although additional configurations are needed:

  • Add output: "server" to astro.config.ts
  • Add export const prerender = true; to the component which uses server:defer

However, as @Trombach mentions, these configs should not be necessary.

Leaving this PR open until further investigation has lead to some fixes.

Related issues

withastro/astro#12803
withastro/astro#12744
withastro/astro#12936
withastro/astro#12982

ToDo

  • Update to later Astro version where temporary fix is not necessary
  • Update this version in changeset
  • Remove temporary fix

Copy link

changeset-bot bot commented Jan 8, 2025

🦋 Changeset detected

Latest commit: 86e0d71

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 🚧 config Configuration file updates 🌏 i18n Updates to internationalized docs, excluding English 📦 package Updates in package structure or package.json 📝 changeset Contains changeset files labels Jan 8, 2025
@trueberryless
Copy link
Member Author

It should work in Astro 5.1.8: withastro/astro#12991

@github-actions github-actions bot removed the 🚧 config Configuration file updates label Jan 29, 2025
@trueberryless trueberryless marked this pull request as ready for review January 29, 2025 17:04
@trueberryless trueberryless merged commit a9f0472 into main Jan 29, 2025
2 checks passed
@trueberryless trueberryless deleted the docs-update branch January 29, 2025 17:05
@trueberryless-org trueberryless-org bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 changeset Contains changeset files 🌏 i18n Updates to internationalized docs, excluding English 📦 package Updates in package structure or package.json
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant