Support for serde(default)
#10
Comments
AlfioEmanueleFresta
added a commit
to linux-credentials/libwebauthn
that referenced
this issue
Feb 24, 2025
## Motivation Makes progress on upstreaming dependency changes, so we can publish our crate. Previous upstreaming request was declined, as COSE types were moved out of `ctap-types`, and into the standalone `cosey` crate (trussed-dev/ctap-types#15). This PR adopts `cosey` for COSE types, and drops our `ctap-types` fork in favour of the published crate. See #54. ## Changes * Remove `ctap-type` fork in favour of: * Fork of `trussed-dev/cosey` for `ctap-type::cose` (this is no longer part of ctap-types). This fork includes the `Deserialize` trait for `PublicKey`, needed in our library. * trussed-dev/cosey#12 * Crate of `trussed-dev/ctap-types` for existing non-COSE uses (eg. `CredentialProtectionPolicy`) * Update `ctap-types` to the latest version * Update `serde-indexed` to 0.1.1 as required by updated `ctap-types` ([Cargo.toml](https://github.com/trussed-dev/ctap-types/blob/496fec4e7370a58d132a66b125483871193e69b5/Cargo.toml#L20)) * Remove `#[serde(default)]` annotation, as this is currently not supported and fails altogether with `serde-indexed 0.1.1`: trussed-dev/serde-indexed#10 ## Follow-up Drop the fork once change is upstreamed: trussed-dev/cosey#12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Proper handling of
defaultshould also fix #2The text was updated successfully, but these errors were encountered: