-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:Update OpenAPI Specification: Rename Schemas and Parameters for Clarity #57
Conversation
WalkthroughThe pull request introduces significant modifications to the OpenAPI specification for the Replicate HTTP API. Key changes include the renaming of several schemas and parameters to improve clarity and consistency. Specifically, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
src/libs/Replicate/openapi.yaml (2)
1001-1001
: LGTM: Parameter definition properly renamed with a suggestion.The prefer header parameter has been properly renamed to
parameters_prefer_header
while maintaining its original functionality.Consider updating any external documentation or API guides to reflect these naming changes to ensure a smooth transition for API consumers.
Line range hint
462-1001
: Consider versioning strategy for breaking changes.The renaming of parameters and schemas, while improving clarity, introduces breaking changes that will affect API clients. Consider:
- Adding a version prefix to the API path (e.g.,
/v2
) for these changes- Providing a migration guide for API consumers
- Maintaining backward compatibility for a transition period
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (33)
src/libs/Replicate/Generated/JsonConverters.SchemasPredictionRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/JsonConverters.SchemasPredictionRequestWebhookEventsFilterItemNullable.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/JsonConverters.SchemasTrainingRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/JsonConverters.SchemasTrainingRequestWebhookEventsFilterItemNullable.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/JsonConverters.SchemasVersionPredictionRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/JsonConverters.SchemasVersionPredictionRequestWebhookEventsFilterItemNullable.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/JsonSerializerContext.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/JsonSerializerContextTypes.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.IReplicateApi.DeploymentsPredictionsCreate.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.IReplicateApi.ModelsPredictionsCreate.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.IReplicateApi.PredictionsCreate.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.IReplicateApi.TrainingsCreate.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.PredictionRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasPredictionRequest.Json.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasPredictionRequest.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasPredictionRequestInput.Json.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasPredictionRequestInput.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasPredictionRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasTrainingRequest.Json.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasTrainingRequest.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasTrainingRequestInput.Json.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasTrainingRequestInput.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasTrainingRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasVersionPredictionRequest.Json.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasVersionPredictionRequest.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasVersionPredictionRequestInput.Json.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasVersionPredictionRequestInput.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.SchemasVersionPredictionRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.Models.TrainingRequestWebhookEventsFilterItem.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.ReplicateApi.DeploymentsPredictionsCreate.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.ReplicateApi.ModelsPredictionsCreate.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.ReplicateApi.PredictionsCreate.g.cs
is excluded by!**/generated/**
src/libs/Replicate/Generated/Replicate.ReplicateApi.TrainingsCreate.g.cs
is excluded by!**/generated/**
📒 Files selected for processing (1)
src/libs/Replicate/openapi.yaml
(8 hunks)
🔇 Additional comments (3)
src/libs/Replicate/openapi.yaml (3)
462-462
: LGTM: Consistent parameter reference renaming.
The prefer header parameter reference has been consistently renamed from prefer_header
to parameters_prefer_header
across all endpoints, improving naming clarity.
Also applies to: 610-610, 746-746
467-467
: LGTM: Consistent schema reference renaming.
Schema references have been consistently renamed with the "schemas_" prefix across all endpoints:
prediction_request
→schemas_prediction_request
training_request
→schemas_training_request
version_prediction_request
→schemas_version_prediction_request
Also applies to: 615-615, 729-729, 751-751
845-845
: LGTM: Schema definitions properly renamed.
The schema definitions have been properly renamed to match their new references while maintaining their original structure and content:
- Line 845:
schemas_prediction_request
- Line 870:
schemas_training_request
- Line 895:
schemas_version_prediction_request
Also applies to: 870-870, 895-895
Summary by CodeRabbit