Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(responsive): unify breakpoint names to small, medium, large, xLarge, xxLarge #88

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

tsutsu3
Copy link
Owner

@tsutsu3 tsutsu3 commented Jan 5, 2025

small (<700) medium (<900) large
s ml l

Copy link

sonarqubecloud bot commented Jan 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
38.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 36.53846% with 33 lines in your changes missing coverage. Please review.

Project coverage is 34.43%. Comparing base (8c99958) to head (9697cbb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/screens/home/home_charts.dart 0.00% 6 Missing ⚠️
lib/screens/home/home.dart 0.00% 5 Missing ⚠️
lib/screens/settings/settings.dart 0.00% 4 Missing ⚠️
...ens/statistics/statistics_queries_servers_tab.dart 0.00% 4 Missing ⚠️
lib/base.dart 0.00% 2 Missing ⚠️
lib/screens/logs/logs_filters_modal.dart 0.00% 2 Missing ⚠️
...p_settings/advanced_settings/advanced_options.dart 33.33% 2 Missing ⚠️
lib/screens/unlock.dart 0.00% 2 Missing ⚠️
lib/screens/logs/logs.dart 66.66% 1 Missing ⚠️
lib/screens/servers/servers.dart 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
+ Coverage   34.41%   34.43%   +0.02%     
==========================================
  Files         136      136              
  Lines        8512     8518       +6     
==========================================
+ Hits         2929     2933       +4     
- Misses       5583     5585       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsutsu3 tsutsu3 merged commit 6743f9a into main Jan 5, 2025
6 of 7 checks passed
@tsutsu3 tsutsu3 deleted the fix/tablet-breakpoint branch January 5, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant