Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a step by step basic usage guide #167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kill9zombie
Copy link

Hopefully this should resolve #150

Adds a basic 'direct use' guide for people not so familiar with front end web development.

However, there is a caveat. At the moment examples downloaded from https://h5p.org/content-types-and-applications
don't seem to have the libraries inside the .h5p file!

The H5P docs don't seem to have changed either, so it looks like the libraries should still be there:
https://h5p.org/documentation/developers/h5p-specification

So as it stands, the guide won't work as is with the h5p.org examples. I think we have three options at the moment:

  1. Wait until H5P Group fix their examples
  2. Wait until H5P Group update their docs (maybe they're moving towards a central download of all content types?)
  3. Add a note in the guide to explain what's going on at the moment

Feel free to edit it. Thank you so much for writing this H5P player!

Phil Helliwell and others added 2 commits February 2, 2025 13:46
Adds a basic usage guide for people not so familiar with
front end web development.

Includes a follow on guide to adding a loading indicator.
Copy link
Collaborator

@0xMurage 0xMurage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m sure the community will find your work incredibly beneficial.

Comment on lines +74 to +86
Now we need to get the zip file from the latest [release](https://github.com/tunapanda/h5p-standalone/releases/latest).

At the time of writing, this is 3.8.0. We can now unzip the release
into our new `assets/h5p-standalone` directory:

```bash
unzip ~/Downloads/h5p-standalone-3.8.0.zip -d assets/h5p-standalone
```

This should create a directory structure something like this:
```bash
find . -type d

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't "basic" users just use the CDN and call it a day?
Something like this https://gist.github.com/0xMurage/50140981a3b540a7ad5c24cc60dbaae3

I think this is a little more hands on.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, yes, good call! I tend to work with offline devices so it's become my default.
Would you like me to grab parts from your gist and use that as the basis for this doc?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to proceed; it's absolutely fine.

Comment on lines +168 to +171
## Fancier spinner

If you'd like a fancier version, you could use some CSS animation
to spin a spinner while the H5P content loads.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this, but including this would not only add extra work to maintain it but stray from main objective. Instructions on how to set up a basic spinner is enough for all intents and purposes.

While a fancier spinner would be great to some people, I don't think it’s suited for inclusion in the repo documentation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, agreed.

@0xMurage
Copy link
Collaborator

The H5P docs don't seem to have changed either, so it looks like the libraries should still be there

We will continue improving the documentation, but for now, it is fine as it is.

I have also noted that exported H5P content no longer includes libraries. This is a positive change in some ways, as content can now reuse libraries, reducing storage space.
However, it also invalidates all existing instructions on how H5P zipped content works and is included. Additionally, setting it up in a standalone H5P player will be a nightmare for beginners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for detailed instructions
2 participants