use single-threaded executor to avoid races when registering Run Conf…

…iguration actions.

Closes #8

README.md

@@ -2,7 +2,7 @@
 
 Plugins for Jetbrains IDEs. It's provides a way to use run configurations as buttons on toolbar. Or assign shortcuts to execute specific run configuration.
 
-Plugin is compatible with all major IDEs based on IntelliJ Platform starting from version 2019.1:
+Plugin is compatible with all major IDEs based on IntelliJ Platform starting from version 2019.2:
 * IntelliJ IDEA
 * Android Studio
 * PhpStorm

resources/META-INF/plugin.xml

@@ -1,7 +1,7 @@
 <idea-plugin>
   <id>org.turbanov.run.configuration.as.action</id>
   <name>Run Configuration as Action</name>
-  <version>1.4.2</version>
+  <version>1.4.3</version>
   <vendor email="turbanoff@gmail.com" url="https://github.com/turbanoff/RunConfigurationAsAction">Turbanov Andrey</vendor>
 
   <description><![CDATA[
@@ -11,6 +11,11 @@ Also it allows to create button in toolbar to run specific configuration.<br>
     ]]></description>
 
   <change-notes><![CDATA[
+    <h3>1.4.3</h3>
+      <ul>
+        <li>Fix race when registering many Run Configurations at once
+        </li>
+      </ul>
     <h3>1.4.2</h3>
       <ul>
         <li>Properly show Run configurations with underscore character.
@@ -45,7 +50,7 @@ Also it allows to create button in toolbar to run specific configuration.<br>
     ]]>
   </change-notes>
 
-  <idea-version since-build="191"/>
+  <idea-version since-build="192"/>
 
   <depends>com.intellij.modules.platform</depends>
 

src/org/turbanov/actions/Bootstrap.java

@@ -23,13 +23,15 @@
 import com.intellij.openapi.util.text.StringUtil;
 import com.intellij.util.IconUtil;
 import com.intellij.util.ImageLoader;
+import com.intellij.util.concurrency.AppExecutorUtil;
 import com.intellij.util.ui.JBImageIcon;
 
 import java.awt.Image;
 import java.io.File;
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
+import java.util.concurrent.ExecutorService;
 
 /**
  * @author Andrey Turbanov
@@ -39,6 +41,7 @@ public class Bootstrap implements ProjectComponent {
     private static final Logger log = Logger.getInstance(RunConfigurationAsAction.class);
     private static final String ACTION_ID_PREFIX = "RunConfigurationAsAction";
     private static final PluginId PLUGIN_ID = PluginId.getId("org.turbanov.run.configuration.as.action");
+    private static final ExecutorService ourExecutor = AppExecutorUtil.createBoundedApplicationPoolExecutor("RunConfigurationAsAction", 1);
 
     private final Project myProject;
 
@@ -117,6 +120,10 @@ private static String makeActionId(@NotNull Executor executor,
     }
 
     public void removeForAllExecutors(@NotNull RunnerAndConfigurationSettings runConfig) {
+        ourExecutor.execute(() -> removeForAllExecutorsImpl(runConfig));
+    }
+
+    private void removeForAllExecutorsImpl(@NotNull RunnerAndConfigurationSettings runConfig) {
         List<Executor> executors = Executor.EXECUTOR_EXTENSION_NAME.getExtensionList();
         ActionManager actionManager = ActionManager.getInstance();
         List<ExecutionTarget> targets = getTargets(runConfig);
@@ -138,7 +145,11 @@ public void removeForAllExecutors(@NotNull RunnerAndConfigurationSettings runCon
         }
     }
 
-    private void registerForAllExecutors(@NotNull RunnerAndConfigurationSettings settings) {
+    private void registerForAllExecutors(@NotNull RunnerAndConfigurationSettings runConfig) {
+        ourExecutor.execute(() -> registerForAllExecutorsImpl(runConfig));
+    }
+
+    private void registerForAllExecutorsImpl(@NotNull RunnerAndConfigurationSettings settings) {
         List<Executor> executors = Executor.EXECUTOR_EXTENSION_NAME.getExtensionList();
         List<ExecutionTarget> targets = getTargets(settings);
         for (Executor executor : executors) {