Skip to content

Commit

Permalink
2018.2 support added
Browse files Browse the repository at this point in the history
  • Loading branch information
turbanoff committed Jun 11, 2018
1 parent d143dca commit fcbab86
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Plugin is compatible with all major IDEs based on IntelliJ Platform starting fro
* WebStorm
* AppCode
* Rider
* Gogland
* GoLand

## Repository link
https://plugins.jetbrains.com/idea/plugin/9448-run-configuration-as-action
Expand Down
13 changes: 9 additions & 4 deletions resources/META-INF/plugin.xml
Original file line number Diff line number Diff line change
@@ -1,16 +1,21 @@
<idea-plugin>
<id>org.turbanov.run.configuration.as.action</id>
<name>Run Configuration as Action</name>
<version>1.1</version>
<version>1.2</version>
<vendor email="turbanoff@gmail.com" url="https://github.com/turbanoff/RunConfigurationAsAction">Turbanov Andrey</vendor>

<description><![CDATA[
Register all run configuration as actions.<br>
It's allows to create button in toolbar to run specific configuration.
Register all run configuration as actions.<br>
Now you can assign shortcuts to run configurations!
Also it allows to create button in toolbar to run specific configuration.<br>
]]></description>

<change-notes><![CDATA[
<h3>1.5</h3>
<h3>1.2</h3>
<ul>
<li>2018.2 support added</li>
</ul>
<h3>1.1</h3>
<ul>
<li>Properly load custom actions to Navigation Bar Toolbar</li>
</ul>
Expand Down
15 changes: 11 additions & 4 deletions src/org/turbanov/actions/Bootstrap.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
import com.intellij.openapi.actionSystem.ActionManager;
import com.intellij.openapi.actionSystem.AnAction;
import com.intellij.openapi.actionSystem.ex.ActionManagerEx;
import com.intellij.openapi.application.ApplicationInfo;
import com.intellij.openapi.components.AbstractProjectComponent;
import com.intellij.openapi.diagnostic.Logger;
import com.intellij.openapi.extensions.PluginId;
Expand Down Expand Up @@ -71,7 +72,7 @@ public void removeForAllExecutors(String runConfigName) {
for (Executor executor : executors) {
String actionId = makeActionId(executor, runConfigName);
AnAction action = actionManager.getAction(actionId);
if (action == null || !(action instanceof RunConfigurationAsAction)) {
if (!(action instanceof RunConfigurationAsAction)) {
continue;
}
int count = ((RunConfigurationAsAction) action).unregister();
Expand Down Expand Up @@ -117,8 +118,14 @@ public void runConfigurationRemoved(@NotNull RunnerAndConfigurationSettings sett
registerForAllExecutors(setting);
}

reloadCustomizedToolbar("NavBarToolBar");
reloadCustomizedToolbar("MainToolBar");
int baseVersion = ApplicationInfo.getInstance().getBuild().getBaselineVersion();
if (baseVersion >= 182) {
//no hacks required in 2018.2+
CustomActionsSchema.setCustomizationSchemaForCurrentProjects();
} else {
reloadCustomizedToolbar("NavBarToolBar");
reloadCustomizedToolbar("MainToolBar");
}
}

private void reloadCustomizedToolbar(String toolbarName) {
Expand All @@ -132,7 +139,7 @@ private void reloadCustomizedToolbar(String toolbarName) {
Field forceUpdate = booleanFields.get("myForceUpdate");
if (forceUpdate == null) {
if (booleanFields.size() != 1) {
log.warn("IDEA version isn't compatible. Plugin can work unstable. CustomisedActionGroup fields: " + booleanFields);
log.warn("IDEA version isn't compatible. Plugin can work unstable. CustomisedActionGroup fields: " + booleanFields.values());
return;
}
forceUpdate = booleanFields.values().iterator().next();
Expand Down

0 comments on commit fcbab86

Please sign in to comment.