Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow environment variables to replace catalog file data tokens. #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kendavis2
Copy link
Contributor

When a catalog file, cstore.yml, is embedded inside a container, a new image is required to change the files[x].data like, AWS_S3_BUCKET. This can cause migrating between AWS accounts or S3 buckets to invalidate past container images preventing deployments of past versions in the new environment.

Allowing the files[x].data to be populated from exported environment variables will increase the portability of existing container images.

context: cstore
files:
- path: service/dev/.env
  store: aws-s3
  type: env
  data:
    AWS_S3_BUCKET: ${S3_BUCKET}
    AWS_STORE_KMS_KEY_ID: ${KMS_KEY_ID}
  tags:
  - service
  - dev
  vaults:
    access: env
    secrets: aws-secrets-manager
  versions: []

Copy link
Collaborator

@dalmena dalmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very elegant solution

@kendavis2 kendavis2 force-pushed the catalogdatatokens branch from f6cb4a1 to 8295c70 Compare May 1, 2020 17:52
@kendavis2
Copy link
Contributor Author

May close this PR since this functionality is supported in https://github.com/dabblebox/stash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants