Update to latest kotlin and Gradle #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Th eexisting version can't even be built on the later Java versions, also it uses way outdated Kotlin and Gradle versions. This PR is my attempt to adress these issues. I also took a librty to use shadow plugin instead of handcrafted uberJar: the old implementation caused an error to appear during the build. However, I tried to preserve as much as was possible. Somehow the plugin build was broken: it generated manifests in wrong places. Now it's fixed too. Also it feels natural these days to use Gradle Version Catalog instead of hardcoded versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Th eexisting version can't even be built on the later Java versions,
also it uses way outdated Kotlin and Gradle versions. This PR is my
attempt to adress these issues.
I also took a librty to use shadow plugin instead of handcrafted
uberJar: the old implementation caused an error to appear during the
build. However, I tried to preserve as much as was possible.
Somehow the plugin build was broken: it generated manifests in wrong
places. Now it's fixed too.
Also it feels natural these days to use Gradle Version Catalog instead
of hardcoded versions.