Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add in github action to upload code coverage results #245

Merged

Conversation

wmundev
Copy link
Collaborator

@wmundev wmundev commented Apr 19, 2024

For this github action to work, a repository secret must be added to this repo CODECOV_TOKEN

See https://docs.codecov.com/docs/quick-start#step-2-get-the-repository-upload-token

@wmundev wmundev requested a review from twcclegg April 19, 2024 10:33
@wmundev wmundev self-assigned this Apr 19, 2024
@twcclegg
Copy link
Owner

I added the token. I believe you have access to GitHub secrets however don’t have access to Codecov; I did not see a way to add you to Codecov.

@wmundev
Copy link
Collaborator Author

wmundev commented Apr 20, 2024

I added the token. I believe you have access to GitHub secrets however don’t have access to Codecov; I did not see a way to add you to Codecov.

thanks @twcclegg ! i think i only have access to create secrets through the gh rest api not through the web interface - https://docs.github.com/en/actions/security-guides/using-secrets-in-github-actions?tool=webui#creating-secrets-for-a-repository

all good though, i can figure out how to use the rest api next time

@wmundev wmundev merged commit 3ce7e19 into twcclegg:main Apr 20, 2024
4 checks passed
@wmundev wmundev deleted the feature/run-code-coverage-and-upload-results branch April 20, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants