Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vfio modules to image #198

Merged
merged 3 commits into from
Feb 8, 2025
Merged

feat: add vfio modules to image #198

merged 3 commits into from
Feb 8, 2025

Conversation

HikariKnight
Copy link
Member

this makes vfio bootc compliant as initramfs regeneration will no longer be required as the modules will be pre-included into initramfs.

@HikariKnight HikariKnight requested a review from NiHaiden February 7, 2025 18:41
@HikariKnight HikariKnight requested a review from inffy as a code owner February 7, 2025 18:41
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Feb 7, 2025
inffy
inffy previously approved these changes Feb 7, 2025
Copy link
Collaborator

@inffy inffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no way to test this but I trust this works ;-)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2025
@HikariKnight
Copy link
Member Author

HikariKnight commented Feb 7, 2025

I have no way to test this but I trust this works ;-)

you can actually test this 80% in a VM, just checking if the vfio modules are included in initramfs will be the tricky part as they dont load unless you bind a gpu (which you cant do in a vm)

NiHaiden
NiHaiden previously approved these changes Feb 7, 2025
@HikariKnight HikariKnight dismissed stale reviews from NiHaiden and inffy via 4478077 February 7, 2025 20:22
Copy link
Collaborator

@ledif ledif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@inffy inffy added this pull request to the merge queue Feb 8, 2025
Merged via the queue into main with commit da1b7a3 Feb 8, 2025
28 checks passed
@inffy inffy deleted the add-vfio-to-image branch February 8, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants