Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup fonts,sddm folder and add gpu-screen-recorder to gaming flatpak just recipe #200

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

dreamyukii
Copy link
Contributor

cleanup fonts and stuff

@dreamyukii dreamyukii requested a review from inffy as a code owner February 8, 2025 11:59
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Feb 8, 2025
packages.json Show resolved Hide resolved
@inffy
Copy link
Collaborator

inffy commented Feb 8, 2025

@NiHaiden @ledif @RealVishy What do you guys think? I think we could really slim down on the fonts we have on the image.

We have embellish and font downloader for people if they need specific fonts..

@inffy inffy requested review from ledif, NiHaiden and RealVishy February 8, 2025 13:40
@NiHaiden
Copy link
Collaborator

NiHaiden commented Feb 8, 2025

@NiHaiden @ledif @RealVishy What do you guys think? I think we could really slim down on the fonts we have on the image.

We have embellish and font downloader for people if they need specific fonts..

I think we can safely remove the Fonts from the system and include something else that will download the fonts people want, like Font Downloader from Flathub. (https://flathub.org/apps/org.gustavoperedo.FontDownloader)

@NiHaiden
Copy link
Collaborator

NiHaiden commented Feb 8, 2025

But Inter Fonts can be kept i think, they might be one of the more used fonts for people.

@inffy
Copy link
Collaborator

inffy commented Feb 8, 2025

@NiHaiden @ledif @RealVishy What do you guys think? I think we could really slim down on the fonts we have on the image.
We have embellish and font downloader for people if they need specific fonts..

I think we can safely remove the Fonts from the system and include something else that will download the fonts people want, like Font Downloader from Flathub. (https://flathub.org/apps/org.gustavoperedo.FontDownloader)

Yes, Font Downloader flatpak is already on the image, and -dx image has also Embellish for managing Nerd fonts.

@ledif
Copy link
Collaborator

ledif commented Feb 8, 2025

This is the current SDDM theme that already has the latest logo:

image

If we look at /usr/share/sddm/themes/01-breeze-fedora/theme.conf, it shows that the logo is actually coming from /usr/share/pixmaps/fedora_whitelogo.svg. This is already set to the new logo.

$ cat /usr/share/sddm/themes/01-breeze-fedora/theme.conf
[General]
showlogo=shown
showClock=true
logo=/usr/share/pixmaps/fedora_whitelogo.svg
type=image
color=#1d99f3
fontSize=10
background=/usr/share/backgrounds/default.png
needsFullUserModel=false

So I think the file system_files/kinoite/usr/share/sddm/themes/01-breeze-fedora/default-logo.svg can simply just be removed.

@dreamyukii
Copy link
Contributor Author

This is the current SDDM theme that already has the latest logo:

image

If we look at /usr/share/sddm/themes/01-breeze-fedora/theme.conf, it shows that the logo is actually coming from /usr/share/pixmaps/fedora_whitelogo.svg. This is already set to the new logo.

$ cat /usr/share/sddm/themes/01-breeze-fedora/theme.conf
[General]
showlogo=shown
showClock=true
logo=/usr/share/pixmaps/fedora_whitelogo.svg
type=image
color=#1d99f3
fontSize=10
background=/usr/share/backgrounds/default.png
needsFullUserModel=false

So I think the file system_files/kinoite/usr/share/sddm/themes/01-breeze-fedora/default-logo.svg can simply just be removed.

done

@dreamyukii dreamyukii changed the title feat: cleanup fonts and change sddm logo to new logo feat: cleanup fonts,sddm folder and add gpu-screen-recorder to gaming flatpak just recipe Feb 8, 2025
RealVishy
RealVishy previously approved these changes Feb 9, 2025
Copy link
Collaborator

@RealVishy RealVishy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to remove the fonts now that we have fontdownloader/embellish. Let's ask on the discourse and then PR removing the fonts it if it's popular?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants