pam/integration-tests: Wait for command prompts text before continuing #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Type in prompt commands we may include slashes, but VHS doesn't escape them properly, so we need to replace them manually with their character-escaped version. See: charmbracelet/vhs#592
…pe commands Add support for TypeInPrompt+Shell command so that we can add specific rules in case we're matching a shell prompt, compared to a standard one
Sometime we're too fast in writing the command and the final character isn't recorded yet by VHS, causing failures that aren't really true. So wait for the whole command being typed before typing enter and continuing. Closes: ubuntu#713
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
=======================================
Coverage 79.05% 79.05%
=======================================
Files 102 102
Lines 10383 10383
Branches 74 74
=======================================
Hits 8208 8208
Misses 1709 1709
Partials 466 466 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometime we're too fast in writing the command and the final character
isn't recorded yet by VHS, causing failures that aren't really true.
So wait for the whole command being typed before typing enter and
continuing.
Closes: #713
UDENG-6180