Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gnome-42-2204] Update libadwaita and add new yaru accent colors #244

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

3v1n0
Copy link
Contributor

@3v1n0 3v1n0 commented Oct 3, 2024

See commits for details.

UDENG-4597

3v1n0 added 3 commits October 3, 2024 11:42
This is what we're doing in the debian patch for a while now, there are
no resulting changes for the computed yaru colors, but it improves links
readability.
This is a new upstream accent color and we should support it in the snap
so that applications running in ubuntu >= 22.10 can use the same accent
that was configured in settings
Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patches seems reasonable. Do we need the libadwaita version update? Reading https://gitlab.gnome.org/GNOME/libadwaita/-/blob/libadwaita-1-4/NEWS there are quite some changes, we will need extra checking of existing snaps if we take the new version, a more selected fix might be a better option if we want to land that fix in Oracular?

@3v1n0
Copy link
Contributor Author

3v1n0 commented Oct 3, 2024

It's a stable update and we've been testing those fixes for long time in noble already, so also checking the code I'm quite confident that they don't break anything, but actually improve various things (including various crash or introspection fixes).

So I might have cherry-picked them, but I believe it's just safer to trust on upstream testing that has been done for some long time now.

Copy link
Contributor

@sergio-costas sergio-costas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible.

@seb128
Copy link
Contributor

seb128 commented Oct 4, 2024

Alright, let's give it a try

@seb128 seb128 merged commit 9036dbc into ubuntu:gnome-42-2204-sdk Oct 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants