Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .deb libtool instead of savannah version #248

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

sergio-costas
Copy link
Contributor

This is to avoid the downloading problems we are having from the Savannah git repo from GNU.

@sergio-costas sergio-costas requested a review from seb128 October 14, 2024 08:31
@3v1n0
Copy link
Contributor

3v1n0 commented Oct 14, 2024

I feel we can just remove the commented code, I feel this is one of those components that taking from the distro is just better than compiling it again in the sdk, being it quite core anyways

Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Marco there, let's just use the deb going forward

@sergio-costas
Copy link
Contributor Author

@seb128 @3v1n0 Commented code removed. Also found that it is using an old .deb for mozjs... preparing a new patch.

@3v1n0
Copy link
Contributor

3v1n0 commented Oct 14, 2024

Thanks, squash the two commits please though.

@sergio-costas
Copy link
Contributor Author

Squashed

@sergio-costas sergio-costas marked this pull request as ready for review October 14, 2024 12:13
@sergio-costas sergio-costas requested a review from seb128 October 14, 2024 12:13
This is to avoid the downloading problems we are having
from the Savannah git repo from GNU.
Copy link
Contributor

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@seb128 seb128 merged commit bec5a3d into ubuntu:gnome-46-2404-sdk Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants