move backoff settings as well as other functions out of utils #1209

AlbertSnows · 2025-01-10T22:12:01Z

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PXP-11392

This PR moves config properties and functions out of utils into config. Utils should be low-level, and thus not reference other namespaces for sake of not inducing circular dependencies.
redesign of #1181

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

moved properties and functions out of utils to config or models to resolve cyclic dependencies

Deployment changes

hash_secret is not used

coveralls · 2025-01-10T22:16:31Z

Pull Request Test Coverage Report for Build 13727398361

Details

0 of 0 changed or added relevant lines in 0 files are covered.
402 unchanged lines in 9 files lost coverage.
Overall coverage increased (+0.2%) to 75.427%

Files with Coverage Reduction	New Missed Lines	%
resources/audit/client.py	11	73.42%
config.py	13	78.46%
resources/openid/ras_oauth2.py	16	58.96%
init.py	20	90.76%
models.py	21	86.68%
utils.py	40	67.59%
resources/google/utils.py	51	77.11%
scripting/google_monitor.py	87	40.5%
scripting/fence_create.py	143	60.5%

Totals
Change from base Build 13573029339:	0.2%
Covered Lines:	7855
Relevant Lines:	10414

💛 - Coveralls

github-actions · 2025-01-10T23:48:20Z

Please find the ci env pod logs here

github-actions · 2025-02-21T18:28:07Z

filepath	$p a s s e d$	$f a i l e d$	$s k i p p e d$	SUBTOTAL
$t e s t s / t e s t_o a u t h 2. p y$	$15$	$0$	$0$	$15$
$t e s t s / t e s t_c e n t r a l i z e d_a u t h . p y$	$16$	$0$	$0$	$16$
$t e s t s / t e s t_d a t a_u p l o a d . p y$	$8$	$0$	$1$	$9$
$t e s t s / t e s t_p r e s i g n e d_u r l . p y$	$7$	$0$	$0$	$7$
$t e s t s / t e s t_u s e r_t o k e n . p y$	$5$	$0$	$0$	$5$
$t e s t s / t e s t_d b g a p . p y$	$3$	$1$	$1$	$5$
$t e s t s / t e s t_d r s_e n d p o i n t . p y$	$4$	$0$	$0$	$4$
$t e s t s / t e s t_r a s_a u t h n . p y$	$3$	$0$	$0$	$3$
$t e s t s / t e s t_o i d c_c l i e n t . p y$	$2$	$0$	$0$	$2$
$t e s t s / t e s t_g o o g l e_d a t a_a c c e s s . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_a u d i t_s e r v i c e . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_c l i e n t_c r e d e n t i a l s . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_r e g i s t e r_u s e r . p y$	$0$	$0$	$2$	$2$
$T O T A L$	$66$	$1$	$4$	$71$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions · 2025-02-21T20:58:53Z

filepath	$p a s s e d$	$f a i l e d$	$s k i p p e d$	SUBTOTAL
$t e s t s / t e s t_o a u t h 2. p y$	$15$	$0$	$0$	$15$
$t e s t s / t e s t_c e n t r a l i z e d_a u t h . p y$	$16$	$0$	$0$	$16$
$t e s t s / t e s t_d a t a_u p l o a d . p y$	$7$	$1$	$1$	$9$
$t e s t s / t e s t_p r e s i g n e d_u r l . p y$	$7$	$0$	$0$	$7$
$t e s t s / t e s t_d b g a p . p y$	$3$	$1$	$1$	$5$
$t e s t s / t e s t_u s e r_t o k e n . p y$	$5$	$0$	$0$	$5$
$t e s t s / t e s t_d r s_e n d p o i n t . p y$	$4$	$0$	$0$	$4$
$t e s t s / t e s t_r a s_a u t h n . p y$	$3$	$0$	$0$	$3$
$t e s t s / t e s t_o i d c_c l i e n t . p y$	$2$	$0$	$0$	$2$
$t e s t s / t e s t_g o o g l e_d a t a_a c c e s s . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_a u d i t_s e r v i c e . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_c l i e n t_c r e d e n t i a l s . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_r e g i s t e r_u s e r . p y$	$0$	$0$	$2$	$2$
$T O T A L$	$65$	$2$	$4$	$71$

Please find the detailed integration test report here

Please find the ci env pod logs here

github-actions · 2025-02-21T21:24:40Z

Please find the ci env pod logs here

piotrsenkow

Everything looks good to me, nice refactoring!

github-actions · 2025-02-28T22:35:31Z

filepath	$p a s s e d$	$f a i l e d$	$e r r o r$	$s k i p p e d$	SUBTOTAL
$t e s t s / t e s t_c e n t r a l i z e d_a u t h . p y$	$0$	$0$	$16$	$0$	$16$
$t e s t s / t e s t_d a t a_u p l o a d . p y$	$0$	$0$	$9$	$0$	$9$
$t e s t s / t e s t_p r e s i g n e d_u r l . p y$	$0$	$0$	$7$	$0$	$7$
$t e s t s / t e s t_d b g a p . p y$	$0$	$0$	$4$	$1$	$5$
$t e s t s / t e s t_d r s_e n d p o i n t . p y$	$0$	$0$	$4$	$0$	$4$
$t e s t s / t e s t_g o o g l e_d a t a_a c c e s s . p y$	$0$	$0$	$1$	$0$	$1$
$t e s t s / t e s t_o a u t h 2. p y$	$15$	$0$	$0$	$0$	$15$
$t e s t s / t e s t_u s e r_t o k e n . p y$	$5$	$0$	$0$	$0$	$5$
$t e s t s / t e s t_r a s_a u t h n . p y$	$3$	$0$	$0$	$0$	$3$
$t e s t s / t e s t_o i d c_c l i e n t . p y$	$1$	$1$	$0$	$0$	$2$
$t e s t s / t e s t_r e g i s t e r_u s e r . p y$	$0$	$0$	$0$	$2$	$2$
$t e s t s / t e s t_a u d i t_s e r v i c e . p y$	$0$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_c l i e n t_c r e d e n t i a l s . p y$	$0$	$1$	$0$	$0$	$1$
$T O T A L$	$24$	$3$	$41$	$3$	$71$

Please find the detailed integration test report here

Please find the ci env pod logs here

fence/config.py

github-actions · 2025-02-28T23:48:05Z

filepath	$p a s s e d$	$f a i l e d$	$s k i p p e d$	SUBTOTAL
$t e s t s / t e s t_o a u t h 2. p y$	$15$	$0$	$0$	$15$
$t e s t s / t e s t_c e n t r a l i z e d_a u t h . p y$	$16$	$0$	$0$	$16$
$t e s t s / t e s t_d a t a_u p l o a d . p y$	$8$	$0$	$1$	$9$
$t e s t s / t e s t_p r e s i g n e d_u r l . p y$	$7$	$0$	$0$	$7$
$t e s t s / t e s t_u s e r_t o k e n . p y$	$5$	$0$	$0$	$5$
$t e s t s / t e s t_d b g a p . p y$	$4$	$0$	$1$	$5$
$t e s t s / t e s t_d r s_e n d p o i n t . p y$	$4$	$0$	$0$	$4$
$t e s t s / t e s t_r a s_a u t h n . p y$	$3$	$0$	$0$	$3$
$t e s t s / t e s t_o i d c_c l i e n t . p y$	$2$	$0$	$0$	$2$
$t e s t s / t e s t_g o o g l e_d a t a_a c c e s s . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_c l i e n t_c r e d e n t i a l s . p y$	$1$	$0$	$0$	$1$
$t e s t s / t e s t_r e g i s t e r_u s e r . p y$	$0$	$0$	$2$	$2$
$t e s t s / t e s t_a u d i t_s e r v i c e . p y$	$0$	$1$	$0$	$1$
$T O T A L$	$66$	$1$	$4$	$71$

Please find the detailed integration test report here

Please find the ci env pod logs here

fence/scripting/google_monitor.py

github-actions · 2025-03-07T18:01:53Z

Please find the ci env pod logs here

AlbertSnows · 2025-03-07T19:10:46Z

PR blocked until ongoing audit issue is resolved

github-actions · 2025-03-07T19:40:40Z

filepath	$S U B T O T A L$
$T O T A L$	$0$

Please find the detailed integration test report here

Please find the ci env pod logs here

AlbertSnows added 6 commits January 10, 2025 15:31

initial migration out of util

8c537f6

get_from_cache is not used

78a4e98

hash_secret is not used

move get_SQLAlchemyDriver to config

94a7756

move send_email to config

0b89e79

move create client to models

af9ade7

fix loading of fence config

282bcda

AlbertSnows changed the title ~~move backoff settings to config~~ move backoff settings as well as other functions out of utils Jan 10, 2025

AlbertSnows mentioned this pull request Jan 10, 2025

[HOLD] move backoff settings, send email, and create client to config #1181

Closed

Merge remote-tracking branch 'origin' into fix/move_backoff_settings_v2

f0ca2af

AlbertSnows and others added 13 commits February 28, 2025 15:45

fix --no-dev issue

62c5031

lock

6619bf4

prints

6e6c02b

more prints

d168a7b

yield different

092d956

remove read

52c7316

add stdout

b6f9e6d

remove prints

ebb4b74

update toml

6e3a779

up toml version

d9a12db

add custom test repo branch

82f4816

Update integration_tests.yaml

9f0a97a

Update integration_tests.yaml

fa66010

piotrsenkow self-requested a review February 28, 2025 22:06

piotrsenkow previously approved these changes Feb 28, 2025

View reviewed changes

paulineribeyre reviewed Feb 28, 2025

View reviewed changes

fence/config.py Outdated Show resolved Hide resolved

move send_email

7cc2af2

AlbertSnows dismissed piotrsenkow’s stale review via 7cc2af2 March 7, 2025 17:35

paulineribeyre reviewed Mar 7, 2025

View reviewed changes

fence/scripting/google_monitor.py Outdated Show resolved Hide resolved

AlbertSnows added 2 commits March 7, 2025 12:54

fix reference to be local for send_email

3e63c41

Merge branch 'master' into fix/move_backoff_settings_v2

851b816

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move backoff settings as well as other functions out of utils #1209

move backoff settings as well as other functions out of utils #1209

AlbertSnows commented Jan 10, 2025 •

edited

Loading

coveralls commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025

github-actions bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

piotrsenkow left a comment

github-actions bot commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

github-actions bot commented Mar 7, 2025

AlbertSnows commented Mar 7, 2025

github-actions bot commented Mar 7, 2025

move backoff settings as well as other functions out of utils #1209

Are you sure you want to change the base?

move backoff settings as well as other functions out of utils #1209

Conversation

AlbertSnows commented Jan 10, 2025 • edited Loading

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

coveralls commented Jan 10, 2025 • edited Loading

Pull Request Test Coverage Report for Build 13727398361

Details

💛 - Coveralls

github-actions bot commented Jan 10, 2025

github-actions bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

github-actions bot commented Feb 21, 2025

piotrsenkow left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 28, 2025

github-actions bot commented Feb 28, 2025

github-actions bot commented Mar 7, 2025

AlbertSnows commented Mar 7, 2025

github-actions bot commented Mar 7, 2025

AlbertSnows commented Jan 10, 2025 •

edited

Loading

coveralls commented Jan 10, 2025 •

edited

Loading