Adds Road Map Feature #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scherztc
force-pushed
the
feature/road_map
branch
6 times, most recently
from
38d1ebc to
2057c0b
Compare
scherztc
force-pushed
the
feature/road_map
branch
3 times, most recently
from
5ea6bbe to
7a2437a
Compare
scherztc
force-pushed
the
feature/road_map
branch
from
7a2437a to
c4bdfa2
Compare
hortongn
requested changes
May 30, 2024
There was a problem hiding this comment.
@scherztc See my comment inline about the size of the edit field. A few other requests:
- When you first land on the list_road_map view, the records should be sorted by title. Right now they're not in order until you click the Title column header.
- See screenshot below. When the roadmap text has several rows, the title is floating in the center vertically. The title should be vertically aligned to the top.
- See screenshot below. When the road map text wraps on the screen, it widens the field and squishes the title field and edit button. Would be nice to have more space for the title and for the "Edit Road Map" button text not to wrap.
- View specs are needed for edit_road_map and list_road_map
I have a couple other enhancements not directly related to this PR that I'll submit new issues for.
scherztc
commented
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340
Run bundle install
Run bundle exec rails db:migrate
Run test suite : coveralls report
Test view in Menu as Owner, Admin, Technician
Test new edit road map experience.
Test new road map on creation and update.