Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove trailing slash from Docker volume targets #45

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

benibr
Copy link
Contributor

@benibr benibr commented Mar 19, 2024

With the new docker compose version I get an error message saying

Error response from daemon: invalid mount config for type "bind": invalid mount path: 'docker-migrid_httpd' mount path must be absolute

when the target path of a volume mount contains a trailing slash.

This PR remove the trailing slashes and adds a troubleshoot section to explain it.

@benibr benibr force-pushed the bugfix/volume-trailing-slash branch from c0a16e9 to 819b074 Compare March 19, 2024 15:27
@benibr
Copy link
Contributor Author

benibr commented Mar 19, 2024

Check fails because untested changes in #43

@jonasbardino jonasbardino merged commit 695aea0 into ucphhpc:master Mar 21, 2024
1 check failed
@jonasbardino
Copy link
Contributor

I think the build breakage is finally fixed after adjusting the bind,ro option in PR 43 and switching over to docker compose as default where available. So I've merged now - let's see if everything still builds.

@jonasbardino
Copy link
Contributor

@benibr benibr deleted the bugfix/volume-trailing-slash branch March 25, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants