Migrate edpickle to bin with linting applied. #197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasbardino
force-pushed
the
adjust/move-edpickle-to-bin-with-lint-fixes
branch
3 times, most recently
from
bc0ae5e to
ea33975
Compare
jonasbardino
added this to the Migration of scripts and services to new FHSesque locations milestone
Modify a bit for python 2+3 support and optional initial file loading while at it, to a.o. ease testing.
constants to use double quotes.
…a `main` function for clarity, and to avoid pylint (bogus) warnings about clearly actual variables not following constant `ALL_CAPS`-format (C0103) when they happen to be in global scope.
…rent dir of command if `import mig` fails.
…ngling `sys.path` when needed and to prevent `vulture` detecting the test helper `import mig` as unused code, when it is only the used to potentially trigger an `ImportError` on insufficient load paths.
… in python module path mangling to prevent mypy 'Incompatible types in assignment' error.
jonasbardino
force-pushed
the
adjust/move-edpickle-to-bin-with-lint-fixes
branch
from
ea33975 to
66c748e
Compare
|
Merged through svn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate edpickle to ./bin/ with
isortandruffcleanup applied.Modify a bit for python 2+3 support and optional initial file loading while at it, to a.o. ease testing.