Merge pull request #4101 from udecode/fix/suggestion

Fix/suggestion
udecode · Feb 21, 2025 · 1eb477f · 1eb477f
2 parents 968faef + 1a6c82e
commit 1eb477f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/mean-lamps-act.md b/.changeset/mean-lamps-act.md
@@ -0,0 +1,5 @@
+---
+'@udecode/plate-suggestion': patch
+---
+
+Fix suggestion `api.node` when pass id.
diff --git a/packages/suggestion/src/lib/BaseSuggestionPlugin.ts b/packages/suggestion/src/lib/BaseSuggestionPlugin.ts
@@ -19,7 +19,7 @@ import type {
   TSuggestionText,
 } from './types';
 
-import { getSuggestionKeyId } from './utils';
+import { getSuggestionKey, getSuggestionKeyId } from './utils';
 import { withSuggestion } from './withSuggestion';
 
 export const SUGGESTION_KEYS = {
@@ -41,7 +41,7 @@ export type BaseSuggestionConfig = PluginConfig<
       dataList: (node: TSuggestionText) => TInlineSuggestionData[];
       isBlockSuggestion: (node: TElement) => node is TSuggestionElement;
       node: (
-        options?: EditorNodesOptions & { isText?: boolean }
+        options?: EditorNodesOptions & { id?: string; isText?: boolean }
       ) => NodeEntry<TSuggestionElement | TSuggestionText> | undefined;
       nodeId: (node: TElement | TSuggestionText) => string | undefined;
       nodes: (
@@ -131,7 +131,7 @@ export const BaseSuggestionPlugin = createTSlatePlugin<BaseSuggestionConfig>({
             if (isText && !TextApi.isText(n)) return false;
             if (id) {
               if (TextApi.isText(n)) {
-                return !!n[getSuggestionKeyId(n)!];
+                return !!n[getSuggestionKey(id)];
               }
               if (
                 ElementApi.isElement(n) &&

diff --git a/packages/suggestion/src/lib/utils/getSuggestionKeys.ts b/packages/suggestion/src/lib/utils/getSuggestionKeys.ts
@@ -8,7 +8,7 @@ import {
 import { BaseSuggestionPlugin } from '../BaseSuggestionPlugin';
 import { getInlineSuggestionData } from './getSuggestionId';
 
-export const getSuggestionKey = (id = '0') =>
+export const getSuggestionKey = (id = '0'): string =>
   `${BaseSuggestionPlugin.key}_${id}`;
 
 export const isSuggestionKey = (key: string) =>