Merge pull request #4146 from udecode/fix/stale-drag-item-element

Fix stale `dragItem.element` causing incorrect drag operations
udecode · Mar 6, 2025 · 88fbc8d · 88fbc8d
2 parents 53e314c + a5d8ebf
commit 88fbc8d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/.changeset/weak-ravens-impress.md b/.changeset/weak-ravens-impress.md
@@ -0,0 +1,5 @@
+---
+'@udecode/plate-dnd': patch
+---
+
+Fix: `onDropNode` uses a stale `element` object for the dragged node, resulting in incorrect drag operations.
diff --git a/packages/dnd/src/hooks/useDragNode.ts b/packages/dnd/src/hooks/useDragNode.ts
@@ -31,8 +31,9 @@ export interface UseDragNodeOptions
  */
 export const useDragNode = (
   editor: PlateEditor,
-  { element, item, ...options }: UseDragNodeOptions
+  { element: staleElement, item, ...options }: UseDragNodeOptions
 ) => {
+  const elementId = staleElement.id as string;
   return useDrag<DragItemNode, unknown, { isDragging: boolean }>(
     () => ({
       collect: (monitor) => ({
@@ -47,16 +48,17 @@ export const useDragNode = (
         document.body.classList.add('dragging');
 
         const _item = typeof item === 'function' ? item(monitor) : item;
+        const [element] = editor.api.node<TElement>({ id: elementId, at: [] })!;
 
         return {
-          id: element.id as string,
+          id: elementId,
           editorId: editor.id,
           element,
           ..._item,
         };
       },
       ...options,
     }),
-    []
+    [editor, elementId]
   );
 };