-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: AI Markdown Parsing #4051
fix: AI Markdown Parsing #4051
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0b7b7eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for the PR! Could you add unit tests? |
@zbeyens Sorry I would add the tests but I don't have the time. Just a downstream user who noticed a problem and wanted to share fix. |
No worries. Could you share a video before/after your changes? |
@zbeyens Here is the final product [ignore the small box that's just how we want it on our page]. |
Thanks for your help @supersimple33 but this is a tricky issue. we don't support multiple paragraph mainly because the following issues. |
@supersimple33 You can use overrideEditor to apply this workaround on your plugin. The plan is to support many blocks without breaking the existing behavior. |
Checklist
yarn typecheck
yarn lint:fix
yarn test
yarn brl
yarn changeset
This PR addresses #4040. I have added a new method which better fills in the ai flag and then I now use the full markdown deserializer.