Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PlateController hook order error and behaviour when editors have no id #4107

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

12joan
Copy link
Collaborator

@12joan 12joan commented Feb 24, 2025

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

The usePlateStore() hook was called conditionally, resulting in the hook order error, and editors previously had no id by default, causing issues with PlateController.

@12joan 12joan requested a review from zbeyens February 24, 2025 17:56
Copy link

codesandbox bot commented Feb 24, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: dc3d72e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@udecode/slate Patch
@udecode/plate-selection Patch
@udecode/plate-toggle Patch
@udecode/plate-core Patch
@udecode/plate-utils Patch
@udecode/plate Patch
@udecode/plate-test-utils Patch
@udecode/plate-ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:27am

@12joan 12joan changed the title Fix PlateController hook order error Fix PlateController hook order error and behaviour when editors have no id Feb 25, 2025
@zbeyens zbeyens merged commit 83ae5f2 into main Feb 25, 2025
4 of 5 checks passed
@zbeyens zbeyens deleted the fix/plate-controller-fallback-hook-order branch February 25, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants