Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cria configuração para o mostrar os colabs no blog #25

Merged
merged 6 commits into from
Feb 24, 2021
Merged

Conversation

arufonsekun
Copy link
Member

@arufonsekun arufonsekun commented Feb 24, 2021

Copy link
Member

@jeanchilger jeanchilger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!! Tudo certo, apenas comentei algumas questões de code style.

@@ -3,7 +3,7 @@ import "./header.scss";
import HeaderImg from "../../assets/images/undraw_teacher_35j2.svg";

class Header extends Component {
render() {
render() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De acordo com a issue #5, haveria um espaço antes do (:

Suggested change
render() {
render () {

Comment on lines 15 to 20
<Helmet>
<meta charSet="utf-8" />
<title>UFFS · NLP</title>
<link rel="canonical" href="https://uffsnlp.github.io" />
<link rel="shortcut icon" type="image/jpg" href={Favicon} />
</Helmet>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acredito que esta declaração não é necessária, pois ela já está definida no MainLayout - a menos que ela inclua informações distintas das já definidas.

@jeanchilger jeanchilger self-requested a review February 24, 2021 20:21
@arufonsekun arufonsekun merged commit 40860f6 into master Feb 24, 2021
@arufonsekun arufonsekun deleted the 23 branch February 24, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Criar estrutura para mostrar colabs na página de blogs
2 participants