-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cria configuração para o mostrar os colabs no blog #25
Conversation
arufonsekun
commented
Feb 24, 2021
•
edited
Loading
edited
- Foi criada a configuração para o build dos colabs;
- Criou-se a página de blog com uma breve descrição;
- closes Criar estrutura para mostrar colabs na página de blogs #23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!! Tudo certo, apenas comentei algumas questões de code style.
src/components/Header/index.jsx
Outdated
@@ -3,7 +3,7 @@ import "./header.scss"; | |||
import HeaderImg from "../../assets/images/undraw_teacher_35j2.svg"; | |||
|
|||
class Header extends Component { | |||
render() { | |||
render() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
De acordo com a issue #5, haveria um espaço antes do (
:
render() { | |
render () { |
src/pages/blog.jsx
Outdated
<Helmet> | ||
<meta charSet="utf-8" /> | ||
<title>UFFS · NLP</title> | ||
<link rel="canonical" href="https://uffsnlp.github.io" /> | ||
<link rel="shortcut icon" type="image/jpg" href={Favicon} /> | ||
</Helmet> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acredito que esta declaração não é necessária, pois ela já está definida no MainLayout
- a menos que ela inclua informações distintas das já definidas.