-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce dependency on SPLIB #889
Reduce dependency on SPLIB #889
Conversation
no longer used. Fixes ufs-community#886.
the lapack_gen.F and splat.F routines from splib are made local files, the dependency on splib can be removed from the makefile. Fixes ufs-community#886.
and 'makeoa'. This will allow for the removal of the calls to splib routine splat. Fixes ufs-community#886.
accordingly. Fixes ufs-community#886.
options were only used for the old spectral GFS terrain. Fixes ufs-community#886.
set in the script and read in. Fixes ufs-community#886.
@AlexanderRichert-NOAA - would you be willing to review? |
Sure. Two things right off the bat: We just merged sp into ip, so these functions are available there. Would it make sense to use the ones available through ip? It would require moving to the latest release, so that's the main tradeoff that comes to mind. |
not to conflict with Orion. Fixes ufs-community#886.
as part of weight_gen program as that is copyrighted. They are working on a possible replacement. Fixes ufs-community#886.
Thanks, I did not realize that I started this work before the final decision was made to merge |
If you keep the 'sp' requirement removed in that CMake config, then I think you'll want to update the root CMakeLists.txt to require ip v5 or higher and remove sp (or add some logic to make it dependent on the ip version number). |
Need to revert this PR. When creating a C96 uniform grid using the scripts in The segmentation fault is consistent on both Hera and Orion. Tests using the
Tile 3 broke here:
This PR was created to reduce the UFS_UTILS dependency on SPLIB. Since it was later decided to merge all of SPLIB into IPLIB, fixing this PR will be low priority. |
This reverts commit 6dee392.
…mmunity#889)" (ufs-community#893) This reverts commit 6dee392.
DESCRIPTION OF CHANGES:
Reduce UFS_UTILS dependency on SPLIB.
orog
program -MAKEMT
,MAKEPC
andMAKEOA
, which were used for the old spectral GFS gaussian grid (and have dependencies on SPLIB) and are now obsolete.TESTS CONDUCTED:
If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.
grid_gen
tests using 1b0dc95. All passed as expected.Describe any additional tests performed.
DEPENDENCIES:
N/A
DOCUMENTATION:
N/A
ISSUE:
Fixes #886.