Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to spack-stack 1.8.0 #985

Closed

Conversation

DavidHuber-NOAA
Copy link
Collaborator

DESCRIPTION OF CHANGES:

This upgrades UFS_Utils to spack-stack 1.8.0. This upgrades a few libraries/packages:
cmake 3.23.1 -> 3.27.9
g2 3.4.5 -> 3.5.1
ip 4.3.3 -> 5.0.0
esmf 8.6.0 -> 8.6.1
nco 5.0.6 -> 5.1.6
wgrib2 2.0.8 -> 3.1.1

Also, as of ip/5.0.0, the sp library functions have been pulled into ip, so sp has been removed. Lastly, the z library has been replaced by zlib-ng. For more details, see the spack-stack v1.8.0 release notes (link to be provided when the release if finalized).

Official installations are not yet in place, so this will remain a draft until all platforms have been migrated for both Intel and GNU compilers. As is, all unit and regression tests pass on Hera when compiled with Intel classic compilers.

Resolves #983

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera, Hercules and WCOSS2).
  • Compile branch on Hera using GNU.
  • Compile branch in 'Debug' mode on WCOSS2.
  • Run unit tests locally on any Tier 1 machine.
  • Run relevant consistency tests locally on all Tier 1 machines.

Optional test.

  • Run full set of chgres_cube consistency tests on Hera.

ISSUE:

If this PR is resolving or referencing one or more issues, in this repository or elsewhere, list them here. For example, "Fixes issue mentioned in #123" or "Related to bug in https://github.com/NOAA-EMC/other_repository/pull/63"

CONTRIBUTORS (optional):

If others have contributed to this work aside from the PR author, list them here

* origin/develop:
  Update the C192 default ocean resolution in the gdas_init utility (ufs-community#980)
  Use HPC-stack libraries on WCOSS2 (ufs-community#975)
  Fix compiler warning in fre-nctools.fd (ufs-community#969)
  Fix Gnu compilation on Hera (ufs-community#965)
  Update fixed data directory path for Gaea (ufs-community#972)
@DavidHuber-NOAA
Copy link
Collaborator Author

The Intel and GCC builds failed due to not being able to find ipolates. I'm not sure if this will require a new build cache, but will look into it in more detail as the work continues.

@DavidHuber-NOAA
Copy link
Collaborator Author

I've been informed by the spack-stack developers that we should wait for version 1.9.0, which will be more stable. Closing.

@LarissaReames-NOAA
Copy link
Collaborator

@DavidHuber-NOAA The RRFS team (cc @natalie-perlin ) need g2v3.4.9+ for a key feature in chgres_cube and that is not available in the present stack, so we'd like to consider upgrading to 1.8.0 at least on Hera. I know you closed this, but it looks like UWM upgraded to 1.8.0 today (PR ufs-community/ufs-weather-model/pull/2453 ) and I was wondering if we could consider revisiting this upgrade (here or in a new PR) to enable this feature for RRFS implementation.

cc @GeorgeGayno-NOAA as we discussed this earlier

@DavidHuber-NOAA
Copy link
Collaborator Author

DavidHuber-NOAA commented Feb 25, 2025

@LarissaReames-NOAA The weather model actually closed that PR as they are planning on moving to spack-stack 1.9.1 instead. See issue ufs-community/ufs-weather-model#2619. I'm open eager to moving forward with 1.9.1 when the weather model is prepared to do the same, but I would prefer not to have multiple repositories on different versions of spack-stack.

@LarissaReames-NOAA
Copy link
Collaborator

Ah, thanks for that clarification. I'd missed that it was closed instead of merged.

I understand not wanting to have multiple spack-stack versions. Just out of curiosity, do you have any idea on a timeline for that upgrade to 1.9.1?

@DavidHuber-NOAA
Copy link
Collaborator Author

I'm not sure when the weather model will have this done, but I expect that the other components will all be ready to go about a month afterwards.

@natalie-perlin
Copy link
Contributor

Could the current UFS_UTILS move to use the spack-stack-1.6.0 environment fms-2024.1? This is the one used by UFS-weather-model currently: /scratch1/NCEPDEV/nems/role.epic/spack-stack/spack-stack-1.6.0/envs/fms-2024.01
It also uses g2/3.5.1, that is sufficient to apply changes for reading large grib2 files.

@natalie-perlin
Copy link
Contributor

@DavidHuber-NOAA @LarissaReames-NOAA - I'd be happy to prepare a PR to move ahead with the ./spack-stack-1.6.0/envs/fms-2024.01

@DavidHuber-NOAA
Copy link
Collaborator Author

@natalie-perlin That would be a great solution! If you would open a PR, I would greatly appreciate it 😄

@natalie-perlin
Copy link
Contributor

@natalie-perlin That would be a great solution! If you would open a PR, I would greatly appreciate it 😄

@DavidHuber-NOAA - Preparing the changes to the modulefiles for the platforms. Is stampede still supported? It is not among the ones for the current ufs-weather-model.

@DavidHuber-NOAA
Copy link
Collaborator Author

@natalie-perlin I'm not sure about stampede. @GeorgeGayno-NOAA would know better than me.

@GeorgeGayno-NOAA
Copy link
Collaborator

@natalie-perlin I'm not sure about stampede. @GeorgeGayno-NOAA would know better than me.

Stampede is not an officially supported machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to spack-stack v1.8.0
4 participants