Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting Canopy Variables from AQM to Facilitate Sub-Canopy Effects in FV3 and CCPP #2630

Draft
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

drnimbusrain
Copy link

Draft PR Task List

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR allows for the "export" of new vegetative canopy fields from the AQM component submodule to FV3 submodule, and subsequently into the CCPP submodule to facilitate new sub-canopy effect parameterizations in respective dependent codes/repositories.

Commit Message:

* UFSWM - Exporting new vegetative canopy variables from AQM component submodule for usage in FV3 component submodule and CCPP  physics submodule
  * AQM - Reads new canopy data files, and exports necessary variables to FV3
    * FV3 - Reads canopy variables exported from AQM for usage in CCPP physics submodule
    * ccpp-physics - Uses canopy variables from FV3 in PBL physics scheme for sub-canopy effects on diffusivity

Priority:

  • Normal.

Git Tracking

UFSWM:

  • Closes #
  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

We have not run an FV3/AQM RT yet for the new sub-canopy effect option, or a full RT suite with all necessary canopy data needed (at required) staged on Hera yet. We request support/assistance with setting this up @BrianCurtis-NOAA. With option = false by default, we anticipate no baseline changes to results, but when set to true, the sub-canopy effects will change baselines.

Input data Changes:

Yes, new canopy data input files are needed and are read through AQM component into FV3/CCPP. The files for the UFS-AQM regional NA domain at 13 km are found on Hera locally at: /scratch2/NAGAPE/arl/Patrick.C.Campbell/RRFS_CMAQ/fix/canopy/AQM_NA_13km/gfs.t12z.geo.*

Library Changes/Upgrades:

** SPECIAL INSTRUCTIONS **

  • No Updates

@iri


Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

zmoon and others added 30 commits October 5, 2022 19:49
Update AQM to current noaa-oar-arl:develop head
- build system updates from upstream
- wet deposition fix from @rmontuoro
now consistent with upstream develop AQM, but keeping
the canopy changes
fixed 2 bugs introduced in the last upstream merge
cleanup/fix from last merge(s)
This reverts commit 27fdc5c.

For our develop branch, we should try to stay closer to upstream
+ update to our new fv3atm develop hash
Also updated FV3 hash to our current develop
(Patrick updated it earlier)
updating FV3 hash to current develop in our fork
Patrick updated it 4 days ago
no changes to AQM
(upstream develop branch hasn't changed since Mar 2023)

set FV3 to Patrick's recent commit changing CCPP repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants