-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exporting Canopy Variables from AQM to Facilitate Sub-Canopy Effects in FV3 and CCPP #2630
Draft
drnimbusrain
wants to merge
32
commits into
ufs-community:develop
Choose a base branch
from
noaa-oar-arl:feature/aqm_canopy_2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Exporting Canopy Variables from AQM to Facilitate Sub-Canopy Effects in FV3 and CCPP #2630
drnimbusrain
wants to merge
32
commits into
ufs-community:develop
from
noaa-oar-arl:feature/aqm_canopy_2
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AQM to current noaa-oar-arl:develop head
- build system updates from upstream - wet deposition fix from @rmontuoro
now consistent with upstream develop AQM, but keeping the canopy changes
fixed 2 bugs introduced in the last upstream merge
cleanup/fix from last merge(s)
This reverts commit 27fdc5c. For our develop branch, we should try to stay closer to upstream
+ update to our new fv3atm develop hash
Also updated FV3 hash to our current develop (Patrick updated it earlier)
updating FV3 hash to current develop in our fork Patrick updated it 4 days ago
no changes to AQM (upstream develop branch hasn't changed since Mar 2023) set FV3 to Patrick's recent commit changing CCPP repos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR Task List
Description:
This PR allows for the "export" of new vegetative canopy fields from the AQM component submodule to FV3 submodule, and subsequently into the CCPP submodule to facilitate new sub-canopy effect parameterizations in respective dependent codes/repositories.
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Changes
Regression Test Changes (Please commit test_changes.list):
We have not run an FV3/AQM RT yet for the new sub-canopy effect option, or a full RT suite with all necessary canopy data needed (at required) staged on Hera yet. We request support/assistance with setting this up @BrianCurtis-NOAA. With option = false by default, we anticipate no baseline changes to results, but when set to true, the sub-canopy effects will change baselines.
Input data Changes:
Yes, new canopy data input files are needed and are read through AQM component into FV3/CCPP. The files for the UFS-AQM regional NA domain at 13 km are found on Hera locally at: /scratch2/NAGAPE/arl/Patrick.C.Campbell/RRFS_CMAQ/fix/canopy/AQM_NA_13km/gfs.t12z.geo.*
Library Changes/Upgrades:
** SPECIAL INSTRUCTIONS **
@iri
Testing Log: