Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation of key_path block. #574

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

christinaholtNOAA
Copy link
Collaborator

Synopsis

Follow up to previous change to naming conventions of the Driver config attributes. When a key_path is provided, use the block within the key_path to validate the platform section as well.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

Copy link
Collaborator

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked so familiar until I realize that I made this fix -- but only on the Assets class, not on Driver. Sorry about that.

@christinaholtNOAA christinaholtNOAA merged commit dfdb466 into ufs-community:main Aug 16, 2024
2 checks passed
@maddenp-noaa maddenp-noaa mentioned this pull request Aug 17, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants