Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow any UPP namelist values to be set. #575

Conversation

christinaholtNOAA
Copy link
Collaborator

Synopsis

UPP Driver users need to more flexibility as they are adding new namelist settings.

We may want to consider making this change to all drivers.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA
Copy link
Collaborator Author

I haven't added tests here just yet...I'd like to get feedback on whether we should open up all namelist settings in a similar way first.

@maddenp-noaa
Copy link
Collaborator

If we have to do this for any specific driver, then we have to. The problem is that this weakens the namelist schema check significantly: Any misspelled key will now be accepted, and we won't be able to advise the user that they've made a mistake. What we previously settled on was: Use strict namelist schemas for components that are unlikely to be under active development, and leave actively-developed component namelist schemas more open. Is that no longer viable?

Out of curiosity, what was the immediate need for this change? Are there changes to UPP that aren't reflected in our schema?

@christinaholtNOAA
Copy link
Collaborator Author

This change will significantly weaken the power of uwtools to catch problems with preparing a namelist. We chose in group to instead add the requested field for the GSL developer since it's likely to go into UPP at some point, and to move toward making changes that will allow a user to specify their own schema for uwtools drivers in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature Added functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants