Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing namelist option to UPP Schema. #576

Merged
merged 6 commits into from
Aug 16, 2024
Merged

Add missing namelist option to UPP Schema. #576

merged 6 commits into from
Aug 16, 2024

Conversation

christinaholtNOAA
Copy link
Collaborator

Synopsis

User reported missing namelist option in JSON Schema. This fixes that omission. It also adds the new option for submodelname = MPAS to the enum list. This will be an upcoming addition to UPP.

Type

  • Bug fix (corrects a known issue)
  • Code maintenance (refactoring, etc. without behavior change)
  • Documentation
  • Enhancement (adds new functionality)
  • Tooling (CI, code-quality, packaging, revision-control, etc.)

Impact

  • This is a breaking change (changes existing functionality)
  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@christinaholtNOAA christinaholtNOAA added the bug Something isn't working label Aug 16, 2024
@christinaholtNOAA christinaholtNOAA self-assigned this Aug 16, 2024
maddenp-noaa
maddenp-noaa approved these changes Aug 16, 2024
View reviewed changes
Copy link
Collaborator

@maddenp-noaa maddenp-noaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind doing the version bump to 2.4.1 in recipe/meta.json and src/uwtools/resources/info.json to save a step in the upcoming release process?

@christinaholtNOAA christinaholtNOAA merged commit 1365b39 into ufs-community:main Aug 16, 2024
2 checks passed
maddenp-noaa pushed a commit to maddenp-noaa/uwtools that referenced this pull request Aug 16, 2024
@christinaholtNOAA @maddenp-noaa
Add missing namelist option to UPP Schema. (ufs-community#576)
a5b4ca8 
User reported missing namelist option in JSON Schema. This fixes that omission. It also adds the new option for submodelname = MPAS to the enum list. This will be an upcoming addition to UPP.
@maddenp-noaa maddenp-noaa mentioned this pull request Aug 16, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WeirAE WeirAE WeirAE approved these changes

@maddenp-noaa maddenp-noaa maddenp-noaa approved these changes

@elcarpenterNOAA elcarpenterNOAA elcarpenterNOAA approved these changes

@NaureenBharwaniNOAA NaureenBharwaniNOAA Awaiting requested review from NaureenBharwaniNOAA NaureenBharwaniNOAA is a code owner

@fgabelmannjr fgabelmannjr Awaiting requested review from fgabelmannjr

Assignees

@christinaholtNOAA christinaholtNOAA

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christinaholtNOAA @WeirAE @maddenp-noaa @elcarpenterNOAA