-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH 677 First Pass: Glob-Style Wildcards #697
GH 677 First Pass: Glob-Style Wildcards #697
Conversation
There's currently a problem with the Binder website that's causing the documentation build to fail during link checking. It's probably a transient issue, but we'll see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Synopsis
This PR provides an implementation of glob-based wildcards for use in
fs copy
andfs link
modes. #677 calls for!regex
support, too, but I'd like to PR this first part to make sure we all agree on the direction. Please see the rendered RtD docs for examples of the new feature in action.I overhauled the docs under
docs/sections/user_guide/cli/tools/fs
to simplify names and improve the overall structure, so there are a lot of fairly trivial diffs there. By far most of the PR diffs, in fact, so don't panic.Type
Impact
Checklist