Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH 677 First Pass: Glob-Style Wildcards #697

Merged
merged 26 commits into from
Feb 20, 2025

Conversation

maddenp-noaa
Copy link
Collaborator

@maddenp-noaa maddenp-noaa commented Feb 15, 2025

Synopsis

This PR provides an implementation of glob-based wildcards for use in fs copy and fs link modes. #677 calls for !regex support, too, but I'd like to PR this first part to make sure we all agree on the direction. Please see the rendered RtD docs for examples of the new feature in action.

I overhauled the docs under docs/sections/user_guide/cli/tools/fs to simplify names and improve the overall structure, so there are a lot of fairly trivial diffs there. By far most of the PR diffs, in fact, so don't panic.

Type

  • Documentation
  • Enhancement (adds new functionality)

Impact

  • This is a non-breaking change (existing functionality continues to work as expected)

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Feb 15, 2025
@maddenp-noaa
Copy link
Collaborator Author

There's currently a problem with the Binder website that's causing the documentation build to fail during link checking. It's probably a transient issue, but we'll see.

Copy link
Collaborator

@elcarpenterNOAA elcarpenterNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@NaureenBharwaniNOAA NaureenBharwaniNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maddenp-noaa maddenp-noaa merged commit 539ce2f into ufs-community:main Feb 20, 2025
2 checks passed
@maddenp-noaa maddenp-noaa deleted the gh-677-wildcards branch February 20, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants