feat(preset-umi): support to preload route chunk files #12095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Size Change: +4.16 kB (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12095 +/- ##
==========================================
- Coverage 28.76% 28.48% -0.29%
==========================================
Files 489 492 +3
Lines 14968 15119 +151
Branches 3560 3601 +41
==========================================
+ Hits 4305 4306 +1
- Misses 9897 10041 +144
- Partials 766 772 +6 ☔ View full report in Codecov by Sentry. |
PeachScript
changed the title
PeachScript
force-pushed
the
feature/route-chunks-prefetch
branch
from
7fc7f43 to
f9c509a
Compare
PeachScript
changed the title
sorrycc
requested changes
Feb 27, 2024
| if (routePath) { | ||
| const map = '{{routeChunkFilesMap}}' as any; | ||
| const doc = document; | ||
| const head = doc.head; |
There was a problem hiding this comment.
head 应该是始终存在的，因为脚本插入时机是 addHTMLHeadScripts
packages/preset-umi/src/features/firstRoutePreload/firstRoutePreload.ts
Outdated
Show resolved
Hide resolved
fz6m
reviewed
Feb 27, 2024
| @@ -2,11 +2,19 @@ import { checkVersion } from '@umijs/utils'; | |||
| import { IApi } from '../../types'; | |||
|
|
|||
| export default (api: IApi) => { | |||
| api.describe({ | |||
| enableBy: () => Boolean(process.env.OKAM), | |||
There was a problem hiding this comment.
process.env.OKAM 有整合的思路吗，现在代码里好几处飞线的 process.env.OKAM 散落在各处。
There was a problem hiding this comment.
整合的话似乎只能挂 service 上，消费的地方都能拿到 api
packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
Outdated
Show resolved
Hide resolved
packages/preset-umi/src/features/routePreloadOnLoad/routePreloadOnLoad.ts
Outdated
Show resolved
Hide resolved
fz6m
approved these changes
Feb 28, 2024
sorrycc
approved these changes
Feb 29, 2024
|
由于 |
|
可以增加个开关吗？ |
可能是脚本插入到 qiankun 改 publicPath 的脚本后面了，ref: umi/packages/plugins/src/qiankun/slave.ts Line 177 in 56313d4 有空的话帮忙验证下上面的猜想，如果确认欢迎提个 PR 调整下 preload 插件插入 headScripts 的钩子 stage 优先级，可以挪到最后面 |
我本地开启nginx 测试了下，换了个位置后，错误信息没有提示出来了 |
我部署的代码验证还是有问题。主应用base为 /base-web，publicPath为：/static-base-web/ 子应用base为 /child-web，publicPath为：/static-child-web/ 升级到最新版umi后发现预加载子应用的js和css 都是不带/static-child-web/的 导致控制台看起来一大片404。于是回退umi到4.1.5版本 发现功能正常 不会有预加载的404 求问如何解决 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持根据访问路由预加载子路由 chunk 文件，主要改动点：
api.appData.bundler的逻辑，用于标记预加载脚本script模式为默认值会在 HTML 产物中插入 inline script，该 script 会根据访问路由自动添加 async script 标签和 preload link 标签预加载访问该子路由需要的所有资源（不含子路由渲染逻辑内的异步加载资源）；而map模式则会输出路由资源映射表，配合 Umi 提供的方法可以在微前端等场景实现自定义的资源预加载（仅用于内部场景）补下原理示意图：
