-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(preset-umi): wrong async script mark for pre-prendered static site app #12216
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: +46 B (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12216 +/- ##
=======================================
Coverage 28.41% 28.41%
=======================================
Files 492 492
Lines 15156 15156
Branches 3620 3621 +1
=======================================
Hits 4306 4306
- Misses 10078 10079 +1
+ Partials 772 771 -1 ☔ View full report in Codecov by Sentry. |
修复静态站点预渲染的时候,可能出现错误的 async script 标记的问题,原因是
markupArgs
对象被重复使用了,解法是根据是否开启预渲染拆分为defaultMarkupArgs
和asyncMarkupArgs
,这样也能避免重复执行带来不必要的开销ref: #11469
cc @MadCcc