-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(preset-umi): chainWebpack hook args for ssr bundling #12217
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Size Change: +13 B (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12217 +/- ##
=======================================
Coverage 28.41% 28.41%
=======================================
Files 492 492
Lines 15156 15156
Branches 3620 3620
=======================================
Hits 4306 4306
Misses 10078 10078
Partials 772 772 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
严格的说这个地方造成了一个 esbuild ssr 和 webpack ssr 的不一致,但应该早点把 esbuild ssr 逻辑下掉,默认使用 webpack 作为 bundler ,你们内部还有项目在用 esbuild ssr 吗,如果只是个别人的话,感觉可以直接切了。
内部和社区估计都没人用 esbuild ssr,明天周会讨论下是不是直接切掉 |
修复 ssr 产物构建前,触发
chainWebpack
钩子缺少参数的问题,以及加上了ssr: true
的标记便于插件区分当前的 webpack 配置目标