Add Borrowed variants to casemapper types #6088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
casemap-borrowed
branch
from
ad639a2 to
b01dca4
Compare
Manishearth
force-pushed
the
casemap-borrowed
branch
from
b01dca4 to
119e77d
Compare
sffc
previously approved these changes
Feb 9, 2025
Manishearth
force-pushed
the
casemap-borrowed
branch
from
5cde139 to
eefe405
Compare
Manishearth
force-pushed
the
casemap-borrowed
branch
from
eefe405 to
97071c0
Compare
sffc
approved these changes
Feb 9, 2025
| @@ -611,12 +611,13 @@ impl CaseMapper { | |||
| /// ); | |||
| /// ``` | |||
| #[cfg(feature = "compiled_data")] | |||
| #[allow(clippy::new_ret_no_self)] // Intentional | |||
There was a problem hiding this comment.
Thought: Rather than saying "Intentional" we should link to an issue or style guide chapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main bit of work in #5440 (does not fix it, since an audit still needs to be performed)
Also useful for bionic to reduce codesize.