You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the documentation on how to verify.
Upgrading
If upgrading from a different minor version, be sure to read the upgrading documentation.
ArgoCD Namespace Isolation Break in github.com/argoproj/argo-cd
github.com/aws/aws-sdk-go1.55.5 (golang)
pkg:golang/github.com/aws/aws-sdk-go@1.55.5
Affected range
>=0
Fixed version
Not Fixed
Description
A padding oracle vulnerability exists in the AWS S3 Crypto SDK for GoLang versions prior to V2. The SDK allows users to encrypt files with AES-CBC without computing a Message Authentication Code (MAC), which then allows an attacker who has write access to the target's S3 bucket and can observe whether or not an endpoint with access to the key can decrypt a file, they can reconstruct the plaintext with (on average) 128*length (plaintext) queries to the endpoint, by exploiting CBC's ability to manipulate the bytes of the next block and PKCS5 padding errors. It is recommended to update your SDK to V2 or later, and re-encrypt your files.
Affected range
>=0
Fixed version
Not Fixed
Description
A vulnerability in the in-band key negotiation exists in the AWS S3 Crypto SDK for GoLang versions prior to V2. An attacker with write access to the targeted bucket can change the encryption algorithm of an object in the bucket, which can then allow them to change AES-GCM to AES-CTR. Using this in combination with a decryption oracle can reveal the authentication key used by AES-GCM as decrypting the GMAC tag leaves the authentication key recoverable as an algebraic equation. It is recommended to update your SDK to V2 or later, and re-encrypt your files.
Unclear documentation of the error behavior in ParseWithClaims can lead to situation where users are potentially not checking errors in the way they should be. Especially, if a token is both expired and invalid, the errors returned by ParseWithClaims return both error codes. If users only check for the jwt.ErrTokenExpired using error.Is, they will ignore the embedded jwt.ErrTokenSignatureInvalid and thus potentially accept invalid tokens.
Fix
We have back-ported the error handling logic from the v5 branch to the v4 branch. In this logic, the ParseWithClaims function will immediately return in "dangerous" situations (e.g., an invalid signature), limiting the combined errors only to situations where the signature is valid, but further validation failed (e.g., if the signature is valid, but is expired AND has the wrong audience). This fix is part of the 4.5.1 release.
Workaround
We are aware that this changes the behaviour of an established function and is not 100 % backwards compatible, so updating to 4.5.1 might break your code. In case you cannot update to 4.5.0, please make sure that you are properly checking for all errors ("dangerous" ones first), so that you are not running in the case detailed above.
token, err:=/* jwt.Parse or similar */if token.Valid {
fmt.Println("You look nice today")
} elseiferrors.Is(err, jwt.ErrTokenMalformed) {
fmt.Println("That's not even a token")
} elseiferrors.Is(err, jwt.ErrTokenUnverifiable) {
fmt.Println("We could not verify this token")
} elseiferrors.Is(err, jwt.ErrTokenSignatureInvalid) {
fmt.Println("This token has an invalid signature")
} elseiferrors.Is(err, jwt.ErrTokenExpired) ||errors.Is(err, jwt.ErrTokenNotValidYet) {
// Token is either expired or not active yetfmt.Println("Timing is everything")
} else {
fmt.Println("Couldn't handle this token:", err)
}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
2.13.3->2.13.4Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
argoproj/argo-cd (argoproj/argo-cd)
v2.13.4Compare Source
Quick Start
Non-HA:
HA:
Release Signatures and Provenance
All Argo CD container images are signed by cosign. A Provenance is generated for container images and CLI binaries which meet the SLSA Level 3 specifications. See the documentation on how to verify.
Upgrading
If upgrading from a different minor version, be sure to read the upgrading documentation.
Changelog
Bug fixes
2fe4536: fix(appset): events not honouring configured namespaces (#21219) (#21241) (#21520) (@eadred)99aaf43: fix: Policy/policy.open-cluster-management.io stuck in progressing status when no clusters match the policy (#21296) (cherry-pick #21297) (#21594) (@gcp-cherry-pick-bot[bot])2618ccc: fix: login return_url doesn't work with custom server paths (cherry-pick #21588) (#21603) (@gcp-cherry-pick-bot[bot])53dc116: fix: oras-go client should fallback to docker config if no credentials specified (cherry-pick 2.13 #18133) (#20872) (@eestolano)fd67e49: fix: resolve the failing e2e appset tests for ksonnet applications (cherry-pick #21580) (#21605) (@gcp-cherry-pick-bot[bot])Documentation
c0f847f: docs: Update Screenshot in Orphaned Resources Monitoring Section #20510 (cherry-pick #20533) (#21489) (@gcp-cherry-pick-bot[bot])c8a62bb: docs: add mkdocs configuration stanza to .readthedocs.yaml (cherry-pick #21475) (#21609) (@gcp-cherry-pick-bot[bot])Dependency updates
2e794fb: chore(deps): bump github.com/go-git/go-git/v5 from 5.12.0 to 5.13.0 (cherry-pick #21329) (#21401) (@gcp-cherry-pick-bot[bot])38e02ab: chore(deps): bump go-git version to go-git/v5 5.13.1 (#21551) (@aali309)Other work
49163b0: Fix application url for custom base href (#21377) (#21515) (@gcp-cherry-pick-bot[bot])10b9589: Merge commit from fork (@svghadi)Full Changelog: argoproj/argo-cd@v2.13.3...v2.13.4
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.